Created attachment 225304 [details] fix ECHO use ECHO is silenced by "make -s" invoke breaking gem plist generation....
I'd suggest fixing all cases of ${ECHO} use in Mk/* in a single commit, e.g. in Mk/Uses/apache.mk and couple of others.
I'd also suggest portmgr picking up the concern of the constant taint in ports and framework since clearly this situation is unwanted and causes all sorts of build problems for individual ports consumers.
I really don't want to impose, but it's also not great to have outside contributions sidelined like this. It's a single line commit with a clear scope and no side effects. If I can help push this further I will... Cheers, Franco
(In reply to Franco Fichtner from comment #3) > I really don't want to impose, but it's also not great to have outside > contributions sidelined like this. No one is sidelining anything. Let's give assigned committer a few more days to handle it; if he's too busy or got sidetracked, I'll help push it forward after that.
Sorry about the hold. As Alexey said, fixing all case of ${ECHO} use in a single commit would be better. I don't have time for searching all use of that. Anyone, please do that.
Created attachment 225720 [details] replace ECHO use in framework Okay, I used following strategy to find stray ECHO use in the framework: # git grep '{ECHO}' [A-Z]* It's not so much here really. The most problems lie in the individual ports and I can propose fixes there too (maybe per category), but will you take this particular patch for the framework first? Cheers, Franco
(In reply to Franco Fichtner from comment #6) > It's not so much here really. You're right, it is not. I'll take care of it.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f16e30b305b5a94cae5e2568913299ced32f0492 commit f16e30b305b5a94cae5e2568913299ced32f0492 Author: Alexey Dokuchaev <danfe@FreeBSD.org> AuthorDate: 2021-06-11 07:34:42 +0000 Commit: Alexey Dokuchaev <danfe@FreeBSD.org> CommitDate: 2021-06-11 07:37:22 +0000 Mk/Uses: replace bare ${ECHO} with ${ECHO_CMD} or ${ECHO_MSG} ECHO is builtin variable and is cleared when make(1) is invoked in silent mode, i.e. as ``make -s'', thus making statements that use it do nothing. Depending on the context, replace it with either ${ECHO_CMD} or ${ECHO_MSG} (in one case), as appropriate. PR: 256185 Submitted by: Franco Fichtner Mk/Uses/apache.mk | 16 ++++++++-------- Mk/Uses/gem.mk | 2 +- Mk/Uses/mono.mk | 2 +- Mk/Uses/perl5.mk | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-)
Thanks, shall I propose category-based patches for individual ports or should this go via another ticket/channel? It's about 275 ports affected from a quick command line check... Cheers, Franco
(In reply to Franco Fichtner from comment #9) > shall I propose category-based patches for individual ports? Not sure, maybe I'll just fix those ports myself, can't decide yet.