Bug 256284 - devel/rcs: obsolete USES=groff makeinfo
Summary: devel/rcs: obsolete USES=groff makeinfo
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-31 07:24 UTC by Helge Oldach
Modified: 2022-12-09 19:19 UTC (History)
4 users (show)

See Also:
portmaster: maintainer-feedback+

Attachments
git diff for: devel/rcs (312 bytes, patch)
2022-12-09 18:25 UTC, Chris Hutchinson 		portmaster: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Helge Oldach 2021-05-31 07:24:57 UTC 
The update to 5.10.0 has added

USES=groff makeinfo

neither of which is needed but dramatically blows up compile time in case these dependences are not pre-installed. I suggest to remove these USES.
Comment 1 Rene Ladan freebsd_committer freebsd_triage 2022-05-02 10:48:50 UTC 
Maintainer reset.
Comment 2 Chris Hutchinson 2022-12-09 18:25:12 UTC 
Created attachment 238670 [details]
git diff for: devel/rcs

@Helge
agreed. no problems will arise from the removal
of groff and makeinfo as USES. If anyone now or
in the future should complain of these changes.
I can always add them as OPTIONS

@Fernando
Thanks for the alert! :-)

--Chris
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2022-12-09 19:19:29 UTC 
Committed,

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-12-09 19:19:39 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d05cc1653c592a4cdbcd2627227dbbfa3f046142

commit d05cc1653c592a4cdbcd2627227dbbfa3f046142
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2022-12-02 07:13:04 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-12-09 19:14:39 +0000

    devel/rcs: remove obsolete USES=groff makeinfo

    While here, regenerate patch.

    PR:             256284
    Reported by:    freebsd@oldach.net
    Approved by:    portmaster@bsdforge.com (maintainer)

 devel/rcs/Makefile                 |  3 ++-
 devel/rcs/files/patch-man-Makefile | 12 ++++++------
 2 files changed, 8 insertions(+), 7 deletions(-)