Bug 256303 - editors/mousepad: Add spell-checking plugin and more
Summary: editors/mousepad: Add spell-checking plugin and more
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-xfce (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-05-31 17:38 UTC by Olivier Duchateau
Modified: 2021-06-03 15:33 UTC (History)
1 user (show)

See Also:
madpilot: maintainer-feedback+

Attachments
Add spell-cheking plugin (2.60 KB, patch)
2021-05-31 17:38 UTC, Olivier Duchateau 		no flags Details | Diff
Add spell checking and other fixes (1.75 KB, patch)
2021-06-01 13:30 UTC, Guido Falsi 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2021-05-31 17:38:42 UTC 
Created attachment 225418 [details]
Add spell-cheking plugin

- Add spell-checking pluging (SPELL option, off by default)
- Adjust dependencies, Mousepad no longer depends of Xfconf
- Bump PORTREVISION
- Add message in order to define default language in gspell plugin, instead the default value (en_US)
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2021-05-31 18:11:03 UTC 
Thanks for the patch.

Testing it.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2021-06-01 07:52:35 UTC 
I have a question:

Why do we need such a convoluted package message and changing the distribution default when the UI has an interface to set the default AND it's going to show English ass default anyway by itself?

I'd simplify the patch and remove the pkg-message, the UI is already simple enough, and mousepad is a GUI software.
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2021-06-01 13:30:49 UTC 
Created attachment 225452 [details]
Add spell checking and other fixes

I'm attaching a revised, simpler patch.

- Removed the pkg-message, which looks unnecessarily complicated.
- Use SPELL_VARS helper in place of including bsd.port.options.mk
- Make SPELL option turned on by default
- Also adding INSTALLS_ICONS to the port, which was missing.

If I don't get feedback I'll proceed with this patch.
Comment 4 Olivier Duchateau 2021-06-02 17:33:47 UTC 
(In reply to Guido Falsi from comment #3)

Patch is fine.

Message suggests to install another dictionary, if native language is not English.
Comment 5 Guido Falsi freebsd_committer freebsd_triage 2021-06-03 10:14:48 UTC 
(In reply to Olivier Duchateau from comment #4)

I think how to install vocabulary ports is outside the scope of mousepad pkg-message, and setting the default is possible via the UI, so I'd rather avoid adding it.

I'm going to commit this patch later.
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-06-03 15:31:31 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cb4dde7e1f4bc930ee4faea4c575ed59eb6d8a6a

commit cb4dde7e1f4bc930ee4faea4c575ed59eb6d8a6a
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2021-06-03 15:29:22 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2021-06-03 15:29:22 +0000

    editors/mousepad: Add spelling support

    - Add new SPELL option enabled by default to compile in spelling
      support
    - Remove unneeded dependency on xfconf
    - Also add missing INSTALLS_ICONS

    PR:     256303

 editors/mousepad/Makefile  | 18 ++++++++++++++----
 editors/mousepad/pkg-plist |  1 +
 2 files changed, 15 insertions(+), 4 deletions(-)
Comment 7 Guido Falsi freebsd_committer freebsd_triage 2021-06-03 15:33:02 UTC 
Committed. Thanks!