Bug 256359 - www/squid-devel: update to 5.0.6
Summary: www/squid-devel: update to 5.0.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/squid-cache/squid/...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-01 22:17 UTC by Pavel Timofeev
Modified: 2021-06-03 09:26 UTC (History)
1 user (show)

See Also:

Attachments
port patch (1.62 KB, patch)
2021-06-01 22:17 UTC, Pavel Timofeev 		timp87: maintainer-approval+
Details | Diff
port patch corrected (859 bytes, patch)
2021-06-02 17:58 UTC, Pavel Timofeev 		timp87: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Timofeev 2021-06-01 22:17:49 UTC 
Created attachment 225483 [details]
port patch

update www/squid-devel to 5.0.6
It contains fix for https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-28116
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2021-06-02 06:32:47 UTC 
Hello!

1- please use DISTVERSION instead of PORTVERSION:
---
Example 2. Using DISTVERSION

When the version only contains numbers separated by dots, dashes or underscores, use DISTVERSION.

PORTNAME=   nekoto
DISTVERSION=	1.2-4

It will generate a PORTVERSION of 1.2.4.

https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-naming
---

2- Send patch only for www/squid-devel and not for www/squid
Comment 2 Pavel Timofeev 2021-06-02 17:58:49 UTC 
Created attachment 225503 [details]
port patch corrected

(In reply to Nuno Teixeira from comment #1)
Thanks for your comments!
Here is an updated patch.
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2021-06-03 07:07:38 UTC 
I will need your name (first, last) so I can commit it with:

git commit --author="Name <email>

Update ready to commit
Comment 4 Pavel Timofeev 2021-06-03 08:56:47 UTC 
(In reply to Nuno Teixeira from comment #3)
Pavel Timofeev <timp87@gmail.com>
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-06-03 09:24:17 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6964f00bccdae0aeb7c2e2adeddbece98731bcb0

commit 6964f00bccdae0aeb7c2e2adeddbece98731bcb0
Author:     Pavel Timofeev <timp87@gmail.com>
AuthorDate: 2021-06-03 09:18:45 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2021-06-03 09:18:45 +0000

    www/squid-devel: update to 5.0.6

    - Use DISTVERSION instead of PORTVERSION

    ChangeLog: https://github.com/squid-cache/squid/pull/817/files#diff-91c5b46dc84a94604a4e4d0caed9bf85590a2eddbb12d2e8dc80badf324a9dfbR1-R14

    PR:             256359
    Approved by:    dbaio, garga (mentors, implicit)

 www/squid-devel/Makefile | 2 +-
 www/squid-devel/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2021-06-03 09:26:15 UTC 
Committed thanks!