Bug 256555 - games/pacmanarena FreeBSD13/14 bugfix
Summary: games/pacmanarena FreeBSD13/14 bugfix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-11 18:22 UTC by David Marec
Modified: 2021-06-15 05:03 UTC (History)
1 user (show)

See Also:

Attachments
remove symbol from header file (1.22 KB, patch)
2021-06-11 18:22 UTC, David Marec 		no flags Details | Diff
remove symbol from header file (1.22 KB, patch)
2021-06-11 18:26 UTC, David Marec 		no flags Details | Diff
remove symbol from header file (1.03 KB, patch)
2021-06-11 18:58 UTC, David Marec 		no flags Details | Diff
remove symbol from header file (1.25 KB, patch)
2021-06-13 19:47 UTC, David Marec 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Marec 2021-06-11 18:22:21 UTC 
Created attachment 225741 [details]
remove symbol from header file

Add a patch to fix "duplicate symbol" compilation error.

No need to define 'keyboard_map' in a header file, as it's only required in 'input.c'.

Review GL dependencies.
Comment 1 David Marec 2021-06-11 18:26:39 UTC 
Created attachment 225742 [details]
remove symbol from header file

Testport succeeded running FreeBSD14.
Comment 2 David Marec 2021-06-11 18:58:36 UTC 
Created attachment 225745 [details]
remove symbol from header file

Remove # $FreeBSD$ from Makefiles.
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2021-06-11 22:52:46 UTC 
^Triage: unfortunately I am way too overcommitted to look after this myself.
Comment 4 David Marec 2021-06-13 19:47:13 UTC 
Created attachment 225772 [details]
remove symbol from header file

Bump port revision
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-06-15 04:54:34 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5b4e16b26a1214e077376dacc664f57f3664f913

commit 5b4e16b26a1214e077376dacc664f57f3664f913
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2021-06-15 04:52:36 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2021-06-15 04:52:47 +0000

    games/pacmanarena: unbreak the build in the -fno-common mode

    Remove needless ``char *keyboard_map'' definition from the header file
    to unbreak the build against modern compilers, e.g. Clang 11 and GCC 10.

    PR:     256555

 games/pacmanarena/Makefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)