Created attachment 226125 [details] Yadifa 2.5.0 Yadifa was updated to 2.5.0 This git diff patch does accordingly. Additional it solves problems mentioned in PR 253842 Tested with portfmt and poudriere
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval. -- Attachment -> Details -> maintainer-approval [+] ^Triage: Maintainer-feedback flag (+) not required unless requested (?) first. There seems to be some options which don't have any consequence in the build of the port. Would you have a look? Q/A: Makefile: DNSSECTOOLS is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MDNSSECTOOLS appears. Makefile: KEYGEN is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MKEYGEN appears. Makefile: ZONESIGN is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MZONESIGN appears. ^Triage: Please confirm this change passes QA (portlint, poudriere at least). -- https://www.freebsd.org/doc/en/books/porters-handbook/testing.html Thanks!
Created attachment 226231 [details] Yadifa 2.5.0
(In reply to Fernando Apesteguía from comment #1) > Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval. > Done. > There seems to be some options which don't have any consequence > According "./configure --help" they disable configure options which are enabled by default. So I trust the vendors info and expect it does make a difference. > Please confirm this change passes QA (portlint, poudriere at least). > Was tested with both, but now also with portclippy and portfmt fully pleased.
(In reply to Leo Vandewoestijne from comment #3) Well, until you added the corresponding _ON / _OFF variables, what were those options doing? Did they have any effect?
(In reply to Fernando Apesteguía from comment #4) It's suppose to do this at configure: --disable-FEATURE do not include FEATURE (same as --enable-FEATURE=no) --enable-FEATURE[=ARG] include FEATURE [ARG=yes] --disable-dnssec-tools Disable DNSSEC module for yadifa --enable-zonesign Enable yadifa zonesign tool --enable-keygen Enable yadifa keygen tool
(In reply to Fernando Apesteguía from comment #4) > Did they have any effect? I can't tell, as I'm not using those features inside Yadifa. But changing the default for at least ZONESIGN did not affect the plist stage in poudriere.
Created attachment 227114 [details] Yadifa 2.5.0 w/o spaces Probably previous patch doesn't apply easily because of spaces instead of tabs. This patch is identical, except for the spaces, so should work easier.
Committed!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d04985d352e9dc1c63061e292734689148909410 commit d04985d352e9dc1c63061e292734689148909410 Author: Leo Vandewoestijne <freebsd@dns.company> AuthorDate: 2021-08-12 14:42:20 +0000 Commit: Neel Chauhan <nc@FreeBSD.org> CommitDate: 2021-08-12 14:43:20 +0000 dns/yadifa: update to 2.5.0 Changes: https://www.yadifa.eu/sites/default/files/README_2.5.0.txt PR: 256900 GIDs | 2 +- UIDs | 2 +- dns/yadifa/Makefile | 19 ++++++++++++++----- dns/yadifa/distinfo | 6 +++--- dns/yadifa/files/yadifad.in | 22 ++++++++++++---------- dns/yadifa/pkg-plist | 31 +++++++++++++++++-------------- 6 files changed, 48 insertions(+), 34 deletions(-)