Created attachment 226237 [details] Diff for arcconf Update arcconf to 3.07.23971 and make it work with FreeBSD 13 (amd64) Port changes: - Use the latest arcconf binary - Use any of the supported GCC Ports instead of limiting to the default one. (this port needs lib libstdc++.so.6 with ABI >= GLIBCXX_3.4.11. FreeBSD base gcc is too old and any compatX port supports only ABI <= GLIBCXX_3.4.9) - Use the correct binary for each Freebsd version (the binary are all the same but just pretend it could be different) - Enable compat12x for FreeBSD 13 support (depends on libncurses.so.8)
Looks good, go ahead
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field. Q/A: Makefile: [31]: use a tab (not space) after a variable name Makefile: version update should not use PORTREVISION. Thomas, would you have a look at this? Thanks!
Created attachment 226273 [details] Updated arcconf diff Removed PORTREVISION. Hopefully replaced space with tab Unfortunately there is no Release Notes for this release. I only see that it includes a FreeBSD 12 directory instead of just 10 and 11. I assume FreeBSD12 is now officially supported.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5ec67c061c6bd9ba6d732d74be9f58e7f67212c7 commit 5ec67c061c6bd9ba6d732d74be9f58e7f67212c7 Author: Fernando Apesteguía <fernape@FreeBSD.org> AuthorDate: 2021-07-06 16:41:01 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2021-07-07 08:21:54 +0000 sysutils/arcconf: Update to 3.07.23971 PR: 256991 Reported by: thomas@bsdunix.ch Reviewed by: michael@fuckner.net (maintainer) sysutils/arcconf/Makefile | 15 ++++++++++----- sysutils/arcconf/distinfo | 6 +++--- 2 files changed, 13 insertions(+), 8 deletions(-)
Committed, Thanks!
The change from USE_GCC=yes to USE_GCC=4.8+ looks like a mistake: we should not be using specific version numbers unless absolutely required and and most modern system USE_GCC=4.8+ has the same effect as USE_GCC=yes anyway. I'll commit an update to address this in a minute. Also, LIB_DEPENDS= libstdc++.so.6:lang/gcc${GCC_DEFAULT} : USE_GCC= 4.8+ seems doubly problematic: GCC_DEFAULT is 10 in most cases, so pulling that in on the one hand, and referring to GCC 4.8 on the other only looks like it's working since 4.8+ really pull in GCC_DEFAULT anyway (unlike plain 4.8 without the +). In fact, what purpose does that LIB_DEPENDS serve? Could/should it be removed?
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4321def1120a64de1ba9726780894b177ffed7ca commit 4321def1120a64de1ba9726780894b177ffed7ca Author: Gerald Pfeifer <gerald@FreeBSD.org> AuthorDate: 2021-07-14 10:52:42 +0000 Commit: Gerald Pfeifer <gerald@FreeBSD.org> CommitDate: 2021-07-14 11:21:01 +0000 sysutils/arcconf: Go with the generic USE_GCC=yes Practically USE_GCC=4.8+ is equivalent to USE_GCC=yes in nearly all cases and version specific dependencies should only be used when unavoidable, so go with USE_GCC=yes. PR: 256991 sysutils/arcconf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)