Created attachment 226525 [details] Screenshot: System Settings The phrases 'Control Center' and 'Look and Feel' are no longer used. Instead: 'System Settings' and 'Appearance'.
<https://www.freshports.org/x11-themes/kde-icons-black-and-white/#message> pkg query %M kde-icons-black-and-white
Thanks for the heads up, Graham. I already have a pr(1) open for this port. I'll make the necessary modifications, and add them to that one, and close this when they're committed. Thanks again! :-) --Chris
Created attachment 226786 [details] git diff for x11-themes/kde-icons-black-and-white This patch addresses the problem reported here, as well as the problem reported in bug #257064. "Killing 2 birds with one stone". I'll close the other bug as a duplicate of this one. Changes Makefile -- removes "Created by", replaces flakey MASTER_SITES. Renames distfile. distinfo -- updates to current standards && uses current distfile name pkg-message -- replaces "Control Center" and "Look and Feel" with "System Settings" and "Appearance" That's it. Thanks! --Chris
*** Bug 257064 has been marked as a duplicate of this bug. ***
(In reply to Chris Hutchinson from comment #3) Why did you removed: "# Created by: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org>"? For what I know this should only be removed when port "creator" decides it so.
(In reply to Nuno Teixeira from comment #5) The # Created by: entry has been depreciated for about a year now. Given I was making a change to the Makefile; I took the opportunity to remove it. As they are no longer used. So hold no value. --Chris
(In reply to Chris Hutchinson from comment #6) My understanding is that it is now discouraged to add "# Created by" line for new ports, but an existing line should not be removed.
(In reply to Guangyuan Yang from comment #7) Do you know why that is? I understand depreciating something doesn't mean its immediate removal. Because doing so might affect the guaranteed stability of a currently supported version. But in this case, I can't understand how after a year, it shouldn't be removed, given it has zero affect on the the port itself. Mind you; I am not trying to argue the point. Just trying to understand. :-) Thanks for taking the time to respond. --Chris
See also: bug #268177
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=743aad0dbc35150bd939db52301c929f6bb711c8 commit 743aad0dbc35150bd939db52301c929f6bb711c8 Author: Chris Hutchinson <portmaster@bsdforge.com> AuthorDate: 2022-12-16 06:47:07 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2022-12-16 16:20:27 +0000 x11-themes/kde-icons-black-and-white: Fix fetch Unbreak port and update pkg-message file. PR: 257242 268177 Reported by: portmaster@bsdforge.com (maintainer) MFH: 2022Q4 (quarterly is also broken) x11-themes/kde-icons-black-and-white/Makefile | 6 ++---- x11-themes/kde-icons-black-and-white/distinfo | 5 +++-- x11-themes/kde-icons-black-and-white/pkg-message | 4 ++-- 3 files changed, 7 insertions(+), 8 deletions(-)
A commit in branch 2022Q4 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f3b5f5fc0afecb2d2627841932db39c1b2193b45 commit f3b5f5fc0afecb2d2627841932db39c1b2193b45 Author: Chris Hutchinson <portmaster@bsdforge.com> AuthorDate: 2022-12-16 06:47:07 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2022-12-16 16:22:01 +0000 x11-themes/kde-icons-black-and-white: Fix fetch Unbreak port and update pkg-message file. PR: 257242 268177 Reported by: portmaster@bsdforge.com (maintainer) MFH: 2022Q4 (quarterly is also broken) (cherry picked from commit 743aad0dbc35150bd939db52301c929f6bb711c8) x11-themes/kde-icons-black-and-white/Makefile | 4 ++-- x11-themes/kde-icons-black-and-white/distinfo | 5 +++-- x11-themes/kde-icons-black-and-white/pkg-message | 4 ++-- 3 files changed, 7 insertions(+), 6 deletions(-)
Done in bug #268177