Bug 257246 - graphics/gnash: Fails to build when RENDERER:CAIRO: gtk/gtk.cpp:36:11: fatal error: 'vaapi_utils.h' file not found
Summary: graphics/gnash: Fails to build when RENDERER:CAIRO: gtk/gtk.cpp:36:11: fatal ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-18 10:51 UTC by Ting-Wei Lan
Modified: 2021-07-19 04:30 UTC (History)
0 users

See Also:
dinoex: maintainer-feedback+
dinoex: merge-quarterly-

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ting-Wei Lan 2021-07-18 10:51:29 UTC 
When choosing CAIRO instead of the default AGG renderer, Gnash fails to build with file not found errors:

gtk/gtk.cpp:36:11: fatal error: 'vaapi_utils.h' file not found
# include "vaapi_utils.h"
          ^~~~~~~~~~~~~~~
4 warnings and 1 error generated.
gmake[5]: *** [Makefile:2875: gtk_gnash-gtk.o] Error 1

It can be worked around by adding CPPFLAGS to '-I../libdevice/vaapi'.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-07-18 10:55:25 UTC 
(In reply to Ting-Wei Lan from comment #0)

Thank you for your report. 

Could you include your proposed change in comment 0 as an attachment please
Comment 2 Ting-Wei Lan 2021-07-18 11:16:23 UTC 
(In reply to Kubilay Kocak from comment #1)
It is just an ugly workaround which is unlikely to be an aceeptable solution ...
Comment 3 Dirk Meyer freebsd_committer freebsd_triage 2021-07-18 19:17:09 UTC 
Thanks, I will test and create a patch myself
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-07-19 04:27:45 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bd1ab07919dc0fb801b9499834731e5f3508e7ad

commit bd1ab07919dc0fb801b9499834731e5f3508e7ad
Author:     Dirk Meyer <dinoex@FreeBSD.org>
AuthorDate: 2021-07-19 04:26:48 +0000
Commit:     Dirk Meyer <dinoex@FreeBSD.org>
CommitDate: 2021-07-19 04:26:48 +0000

    graphics/gnash: fix option CAIRO

    PR:             257246
    Reported by:    Ting-Wei Lan

 graphics/gnash/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 5 Dirk Meyer freebsd_committer freebsd_triage 2021-07-19 04:30:42 UTC 
Fix committed