Bug 257295 - lang/spl: patch and unbreak with -fno-common
Summary: lang/spl: patch and unbreak with -fno-common
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-20 10:04 UTC by Robert Clausecker
Modified: 2021-07-21 08:11 UTC (History)
1 user (show)

See Also:

Attachments
lang/spl: patch and unbreak with -fno-common (2.50 KB, patch)
2021-07-20 10:04 UTC, Robert Clausecker 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2021-07-20 10:04:05 UTC 
Created attachment 226569 [details]
lang/spl: patch and unbreak with -fno-common

This fixes the build with -fno-common (default since FreeBSD 13) and pets portclippy.

Also pick up maintainership for this unmaintained port.

Tested on arm64 FreeBSD 13.0 with Poudriere.
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-07-21 08:09:59 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f11e9f154140bf1d042a9f7fce069e21c3eda2b7

commit f11e9f154140bf1d042a9f7fce069e21c3eda2b7
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-07-20 09:42:55 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2021-07-21 08:07:47 +0000

    lang/spl: patch and unbreak with -fno-common

    PR:             257295

 lang/spl/Makefile                   | 11 ++++-------
 lang/spl/files/patch-libspl.c (new) | 10 ++++++++++
 lang/spl/files/patch-spl.h (new)    | 26 ++++++++++++++++++++++++++
 3 files changed, 40 insertions(+), 7 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-07-21 08:11:00 UTC 
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7d4aa58587ee9cbbada0016fb4b3157e923c66e6

commit 7d4aa58587ee9cbbada0016fb4b3157e923c66e6
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-07-20 09:42:55 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2021-07-21 08:09:45 +0000

    lang/spl: patch and unbreak with -fno-common

    PR:             257295
    (cherry picked from commit f11e9f154140bf1d042a9f7fce069e21c3eda2b7)

 lang/spl/Makefile                   | 11 ++++-------
 lang/spl/files/patch-libspl.c (new) | 10 ++++++++++
 lang/spl/files/patch-spl.h (new)    | 26 ++++++++++++++++++++++++++
 3 files changed, 40 insertions(+), 7 deletions(-)