Created attachment 226611 [details] asgi-lifespan.diff QA: * portlint: OK (looks fine.) * testport: OK (poudriere: 13.0, amd64 tested) * maketest: OK (14 passed, 15 skipped, 1 xfailed, 15 warnings)
Python doesn't need to block / be assignee on new ports
The ports tree has python 3.7 or later. So the folllowing lines in the patch appears no longer necessary: .if ${PYTHON_REL} < 30700 RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}async-exit-stack>=0:devel/py-async-exit-stack@${PY_FLAVOR} .endif
Created attachment 230659 [details] asgi-lifespan.diff
The build is fine. I got the following message when I ran "make test" in a clean jail: ==================================== ERRORS ==================================== ____________________ ERROR collecting tests/test_manager.py ____________________ ImportError while importing test module '/wrkdirs/usr/ports/devel/py-asgi-lifespan/work-py38/asgi-lifespan-1.0.1/tests/test_manager.py'. Hint: make sure your test modules/packages have valid Python names. Traceback: tests/test_manager.py:5: in <module> from starlette.routing import Router E ModuleNotFoundError: No module named 'starlette' !!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!! =========================== 1 error in 0.07 seconds ============================ Probably the "starlette" python module is missing. Could you make it sure that all necessary modules are listed in TEST_DEPENDS?
Since last time I tried to get some help from upstream: https://github.com/florimondmanca/asgi-lifespan/issues/47. So far nobody replied, so when I come with an update I'll post it here. Is there something I need to do with this ticket in the mean time?
Created attachment 238628 [details] asgi-lifespan.patch With upgrade to version 2.0 all obstacles are removed.
Committed, thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b4c9bc97bb146574281e704a28988355ab91dafe commit b4c9bc97bb146574281e704a28988355ab91dafe Author: Goran Mekić <meka@tilda.center> AuthorDate: 2022-12-17 05:41:15 +0000 Commit: Yuri Victorovich <yuri@FreeBSD.org> CommitDate: 2022-12-17 09:14:19 +0000 devel/py-asgi-lifespan: New port: Programmatic startup/shutdown of ASGI apps PR: 257334 devel/Makefile | 1 + devel/py-asgi-lifespan/Makefile (new) | 26 ++++++++++++++++++++++++++ devel/py-asgi-lifespan/distinfo (new) | 3 +++ devel/py-asgi-lifespan/pkg-descr (new) | 4 ++++ 4 files changed, 34 insertions(+)