Bug 257429 - devel/judy: Import patch to fix memory corruption
Summary: devel/judy: Import patch to fix memory corruption
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Li-Wen Hsu
URL: https://sourceforge.net/p/judy/bugs/25/
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-26 08:50 UTC by Daniel Engberg
Modified: 2021-07-31 20:06 UTC (History)
1 user (show)

See Also:
koobs: merge-quarterly?

Attachments
Patch for judy (3.73 KB, patch)
2021-07-26 08:50 UTC, Daniel Engberg 		koobs: maintainer-approval-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2021-07-26 08:50:53 UTC 
Created attachment 226707 [details]
Patch for judy

Import patch to fix memory corruption
Clang also warns about this during compilation such as:
"warning: array index 14 is past the end of the array (whichcontains 8 elements) [-Warray-bounds]"

Source: 
https://github.com/netdata/libjudy/commit/e95874a4e271d0f8535ab78862af3d57d33e9d1e
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-07-26 08:50:59 UTC 
Compile tested on FreeBSD 13.0-STABLE #0 stable/13-n246086-a20c597c6d7 (amd64) (make, make check-plist)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 11.4-RELEASE (amd64)
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2021-07-26 08:58:56 UTC 
Thanks Daniel!
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2021-07-26 08:59:24 UTC 
Comment on attachment 226707 [details]
Patch for judy

^Triage:

Approved by: portmgr (unmaintained port)
MFH: 2020Q3 (blanket: runtime bugfix)
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-07-31 20:05:42 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0e8cb6eb96e1a55e7d57deea3d79b3ba5d6e6ac5

commit 0e8cb6eb96e1a55e7d57deea3d79b3ba5d6e6ac5
Author:     Daniel Engberg <daniel.engberg.lists@pyret.net>
AuthorDate: 2021-07-31 20:03:52 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2021-07-31 20:03:52 +0000

    devel/judy: Import patch to fix memory corruption

    PR:             257429
    Obtained from:  https://github.com/netdata/libjudy/commit/e95874a4e271d0f8535ab78862af3d57d33e9d1e

 devel/judy/Makefile                                |  8 +--
 .../patch-src_JudyCommon_JudyPrivateBranch.h (new) | 63 ++++++++++++++++++++++
 2 files changed, 67 insertions(+), 4 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-07-31 20:06:42 UTC 
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1b1f9cf1172d910ac2478a32f474bb5c60b30b98

commit 1b1f9cf1172d910ac2478a32f474bb5c60b30b98
Author:     Daniel Engberg <daniel.engberg.lists@pyret.net>
AuthorDate: 2021-07-31 20:03:52 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2021-07-31 20:05:49 +0000

    devel/judy: Import patch to fix memory corruption

    PR:             257429
    Obtained from:  https://github.com/netdata/libjudy/commit/e95874a4e271d0f8535ab78862af3d57d33e9d1e

    (cherry picked from commit 0e8cb6eb96e1a55e7d57deea3d79b3ba5d6e6ac5)

 devel/judy/Makefile                                |  8 +--
 .../patch-src_JudyCommon_JudyPrivateBranch.h (new) | 63 ++++++++++++++++++++++
 2 files changed, 67 insertions(+), 4 deletions(-)