Bug 257529 - net/openldap24-server: Fix breakage after SASL changes
Summary: net/openldap24-server: Fix breakage after SASL changes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Xin LI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-01 11:53 UTC by Rainer Hurling
Modified: 2021-08-01 19:10 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (delphij)

Attachments
patch to fix RUN_DEPENDS after using bsd.port.options.mk (533 bytes, patch)
2021-08-01 11:53 UTC, Rainer Hurling 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Hurling freebsd_committer freebsd_triage 2021-08-01 11:53:45 UTC 
Created attachment 226834 [details]
patch to fix RUN_DEPENDS after using bsd.port.options.mk

Hi Xin LI,

Thanks for the SASL changes in net/openldap24-server.


Unfortunetaly there seem to be a breakage with this new code:

#cd net/openldap24-client
#make
/!\ openldap-client-2.4.59_1: Makefile errors /!\

The following options helpers are incorrectly set after bsd.port.options.mk
and are ineffective: GSSAPI_RUN_DEPENDS
*** Error code 1
Stop.


This happens, because GSSAPI_RUN_DEPENDS (in the servers Makefile) is used after '.include <bsd.port.options.mk>'.

The attached patch changes this to old style RUN_DEPENDS in an .if/.endif. This should work as expected, I hope.

Regards,
Rainer
Comment 1 Xin LI freebsd_committer freebsd_triage 2021-08-01 19:10:48 UTC 
Thanks for pointing this out.  I've committed a different patch (to move the option earlier).
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-08-01 19:10:56 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=80df02c5cbfa308542602c54645bbc574031316f

commit 80df02c5cbfa308542602c54645bbc574031316f
Author:     Xin LI <delphij@FreeBSD.org>
AuthorDate: 2021-08-01 19:08:52 +0000
Commit:     Xin LI <delphij@FreeBSD.org>
CommitDate: 2021-08-01 19:10:11 +0000

    net/openldap24-server: Fix GSSAPI dependency

    <OPTION>_RUN_DEPENDS has to appear before bsd.options.mk.

    PR:             257529

 net/openldap24-server/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)