Bug 257795 - math/R: add missing dependency on harfbuzz to CAIROPANGO option
Summary: math/R: add missing dependency on harfbuzz to CAIROPANGO option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joseph Mingrone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-12 21:18 UTC by Philipp Ost
Modified: 2021-08-14 19:51 UTC (History)
2 users (show)

See Also:

Attachments
Add missing harfbuzz library dependency (456 bytes, patch)
2021-08-12 21:18 UTC, Philipp Ost 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Ost 2021-08-12 21:18:15 UTC 
Created attachment 227144 [details]
Add missing harfbuzz library dependency

If CAIROPANGO=on, then /usr/local/lib/R/library/grDevices/libs/cairo.so is linked to /usr/local/lib/libharfbuzz.so.0 from print/harfbuzz but it is not declared as a dependency.

The attached patch adds libharfbuzz.so as a library dependency to the CAIROPANGO option.
Comment 1 Joseph Mingrone freebsd_committer freebsd_triage 2021-08-14 19:33:49 UTC 
Not sure why this didn't get assigned to the maintainer (me).  Taking a look now.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-08-14 19:45:31 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ca96cfcebb5cb8bc01c563daefbe800c8b281e27

commit ca96cfcebb5cb8bc01c563daefbe800c8b281e27
Author:     Philipp Ost <bsd@philippost.de>
AuthorDate: 2021-08-14 19:43:42 +0000
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2021-08-14 19:44:43 +0000

    math/R: Add missing harfbuzz dependency when CAIROPANGO is on

    PR:             257795

 math/R/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 3 Joseph Mingrone freebsd_committer freebsd_triage 2021-08-14 19:51:35 UTC 
Oh, duh.  I didn't get notified because I accidentally dropped maintainership of math/R instead of math/libRmath.

In any case, patch applied.  Thanks.