Created attachment 227299 [details] Update to 2.1.1 Update to 2.1.1 Tested on the freebsd: 11.4-RELEASE-p12 11.4-RELEASE-p12 12.1-RELEASE-p13 12.1-RELEASE-p13 12.2-RELEASE-p9 12.2-RELEASE-p9 13.0-RELEASE-p3 13.0-RELEASE-p3 portlint: no errors
Created attachment 227300 [details] Update to 2.1.1 formating small fixes Hello, What you think about this small styling/formating small fixes: 1. add and extra tab in: --- +USES= go:modules --- so it can be better aligned with rest of variables 2. portclippy is sugesting that GH_TUPLE should be right after GH_PROJECT in USES block and not in USES=go related variables. --- # USES block USES USE_GITHUB GH_PROJECT +GH_TUPLE # USES=go related variables GO_TARGET -GH_TUPLE --- What do you think about this small fixes patch?
(In reply to Nuno Teixeira from comment #1) Thanks Nuno, I'll reorder GH_TUPLE. Not sure about the aligning thing. To me one TAB is enough. And this is not going to be aligned unless we do something with DISTVERSIONPREFIX :-P
(In reply to Fernando Apesteguía from comment #2) Hello! Yes you are right about DISTVERSIONPREFIX. I'm testing portfmt in all ports updates, but most of the times it leads to mistakes. Thats why I'm asking maintainers their opinion about it. Portclippy is almost times very handy like portlint. Thanks
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=03a7c5211d203f98c6c13140f14ccd15b05dd1b9 commit 03a7c5211d203f98c6c13140f14ccd15b05dd1b9 Author: Gabriel Dutra <0xdutra@gmail.com> AuthorDate: 2021-08-18 09:10:17 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2021-08-18 18:23:06 +0000 net/ipinfo-cli: Update to 2.1.1 ChangeLog: https://github.com/ipinfo/cli/releases/tag/ipinfo-2.1.1 PR: 257922 net/ipinfo-cli/Makefile | 6 +++--- net/ipinfo-cli/distinfo | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
Committed, Thanks!