Bug 258003 - lang/gforth: unbreak on armv6 and armv7
Summary: lang/gforth: unbreak on armv6 and armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-23 09:51 UTC by Robert Clausecker
Modified: 2021-08-25 11:00 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (danfe)

Attachments
lang/gforth: unbreak on armv6 and armv7 (678 bytes, patch)
2021-08-23 09:51 UTC, Robert Clausecker 		fuz: maintainer-approval? (danfe)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2021-08-23 09:51:43 UTC 
Created attachment 227376 [details]
lang/gforth: unbreak on armv6 and armv7

With a recent update to devel/libffcall, lang/gforth is no longer ignored on armv6 and armv7.  This patch fixes the insufficient word size check to correctly detect these architectures, making the port build on armv6 and armv7.

Tested with Poudriere on armv7 FreeBSD 13.0-RELEASE.
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-08-25 10:58:42 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=abc8ea44a2171da6cd0f97b44b854e1428d37535

commit abc8ea44a2171da6cd0f97b44b854e1428d37535
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2021-08-25 10:56:26 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2021-08-25 10:56:54 +0000

    lang/gforth: attempt to unbreak the port on i386, armv6, and armv7

    - Partially apply upstream commit 9f35279358 to unbreak the build on i386
    - With a recent update of devel/libffcall in 58a8a0aa37a8, the port is no
      longer ignored on armv6 and armv7.  Amend the word size check so it can
      be built on these architectures

    PR:     258003

 lang/gforth/Makefile                        |  5 ++---
 lang/gforth/files/patch-engine_main.c (new) | 29 +++++++++++++++++++++++++++++
 2 files changed, 31 insertions(+), 3 deletions(-)
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2021-08-25 11:00:19 UTC 
Committed along with other modifications, thanks!