Bug 258008 - shells/starship: enable desktop notifications
Summary: shells/starship: enable desktop notifications
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-08-23 14:09 UTC by Jan Beich
Modified: 2021-08-23 23:33 UTC (History)
0 users

See Also:
jbeich: merge-quarterly+

Attachments
v1 (14.53 KB, patch)
2021-08-23 14:09 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2021-08-23 14:09:20 UTC 
Created attachment 227379 [details]
v1

"show_notifications" requires --features=notify-rust as documented in https://starship.rs/config/#command-duration. Backport a few zbus commits and enable the feature, similar to https://github.com/archlinux/svntogit-community/commit/6a2886e4d3ac

Disclaimer: I don't use this port, so tested zbus standalone via "cargo test" and ports a15225b4441f.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2021-08-23 17:35:58 UTC 
Approved, thank you.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-08-23 23:31:35 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ef5a84db43ef87175ee40b7d4de913ad65ec7c49

commit ef5a84db43ef87175ee40b7d4de913ad65ec7c49
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-08-23 13:51:22 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-08-23 23:30:19 +0000

    shells/starship: enable desktop notifications

    PR:             258008
    Inspired by:    Arch Linux
    Approved by:    yuri (maintainer)

 shells/starship/Makefile               |   5 +-
 shells/starship/distinfo               |   6 -
 shells/starship/files/patch-zbus (new) | 227 +++++++++++++++++++++++++++++++++
 3 files changed, 229 insertions(+), 9 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-08-23 23:32:35 UTC 
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f34b48106e69a6e8d7d261b635d4de09f7af7f73

commit f34b48106e69a6e8d7d261b635d4de09f7af7f73
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-08-23 13:51:22 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-08-23 23:32:06 +0000

    shells/starship: enable desktop notifications

    PR:             258008
    Inspired by:    Arch Linux
    Approved by:    yuri (maintainer)

    (cherry picked from commit ef5a84db43ef87175ee40b7d4de913ad65ec7c49)

 shells/starship/Makefile               |   6 +-
 shells/starship/distinfo               |   6 -
 shells/starship/files/patch-zbus (new) | 227 +++++++++++++++++++++++++++++++++
 3 files changed, 229 insertions(+), 10 deletions(-)