Bug 258109 - astro/gpsd: update to 3.23.1
Summary: astro/gpsd: update to 3.23.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks: 258110 258111 258112
  Show dependency tree / graph
 
Reported: 2021-08-28 00:50 UTC by Steve Wills
Modified: 2022-03-14 00:34 UTC (History)
3 users (show)

See Also:

Attachments
patch to update port (10.72 KB, patch)
2021-08-28 00:50 UTC, Steve Wills 		no flags Details | Diff
patch to update astro/gpsd from 3.20 to 3.23.1 (12.19 KB, patch)
2021-12-25 21:07 UTC, Oleg Sidorkin 		osidorkin: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer freebsd_triage 2021-08-28 00:50:34 UTC 
Created attachment 227499 [details]
patch to update port
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2021-08-28 00:50:34 UTC 
Maintainer informed via mail
Comment 2 Craig Leres freebsd_committer freebsd_triage 2021-09-03 17:22:35 UTC 
Your patchset builds and runs for me (with my javad/greis setup and the pre-existing /dev/pps0 issues I'm currently working on) but I think it's ok to commit this version.

I will note that cgps spits out:

    cgps: WARNING gpsd release 3.20, API: 3.14, expected 3.23

which I don't remember seeing before but it still reports reasonable looking data.

I'll file a new PR if/when I solve gpsd vs /dev/pps0.
Comment 3 Steve Wills freebsd_committer freebsd_triage 2021-09-03 17:47:53 UTC 
(In reply to Craig Leres from comment #2)
Thanks for testing.

FWIW, that message seems to come from:

https://gitlab.com/gpsd/gpsd/-/blob/release-3.23/clients/cgps.c#L610-620

Is it perhaps talking to an older server?
Comment 4 Craig Leres freebsd_committer freebsd_triage 2021-09-03 18:09:02 UTC 
(In reply to Steve Wills from comment #3)
Oops, you're right. Well running with 3.23 also works as well as 3.20.
Comment 5 Charlie Li freebsd_committer freebsd_triage 2021-11-16 23:19:30 UTC 
We're up to 3.23.1 now.

Also need to see if building with Python 3.10 works, since the current version in the tree 3.20 fails due to using distutils for a configure check.
Comment 6 Oleg Sidorkin 2021-12-21 13:20:51 UTC 
Current gpsd is quite easy to patch to build with python 3.10. However it's better to commit a new version.
Comment 7 Oleg Sidorkin 2021-12-25 21:07:48 UTC 
Created attachment 230404 [details]
patch to update astro/gpsd from 3.20 to 3.23.1

My version of patch based on swills@ patch.
Updates gpsd to 3.23.1 with python 3.10 detection fixed.
Probably dependencies can be declared better.
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-03-14 00:33:47 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c77cd8547d0dc016d1871eca349c7e74cc8c2332

commit c77cd8547d0dc016d1871eca349c7e74cc8c2332
Author:     Steve Wills <swills@FreeBSD.org>
AuthorDate: 2022-03-14 00:00:18 +0000
Commit:     Steve Wills <swills@FreeBSD.org>
CommitDate: 2022-03-14 00:31:48 +0000

    astro/gpsd: update to 3.23.1

    PR:             258109
    Approved by:    z7dr6ut7gs@snkmail.com (maintainer timeout, >2 months)

 astro/gpsd/Makefile                      | 110 ++++++++++++++++---------------
 astro/gpsd/distinfo                      |   6 +-
 astro/gpsd/files/patch-SConscript (new)  |  38 +++++++++++
 astro/gpsd/files/patch-SConstruct (gone) |  56 ----------------
 astro/gpsd/pkg-plist                     |  30 +++++++--
 5 files changed, 125 insertions(+), 115 deletions(-)
Comment 9 Steve Wills freebsd_committer freebsd_triage 2022-03-14 00:34:16 UTC 
Update committed