Bug 258185 - net/dhcpcd: Switch keyword from nojail to nojailvnet in rc script.
Summary: net/dhcpcd: Switch keyword from nojail to nojailvnet in rc script.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dries Michiels
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-31 18:08 UTC by Lucas Toole
Modified: 2021-11-13 16:10 UTC (History)
1 user (show)

See Also:
driesm: maintainer-feedback+

Attachments
Diff for nojail -> nojailvnet (295 bytes, patch)
2021-08-31 18:08 UTC, Lucas Toole 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Toole 2021-08-31 18:08:07 UTC 
Created attachment 227573 [details]
Diff for nojail -> nojailvnet

By default dhcpcd has the nojail keyword enabled in the rc script. It was added back in 2007[0] and I assume it is just a remnant of the pre-vnet days. I've been using dhcpcd exclusively in my vnet jails by manually changing the keyword to nojailvnet (Only allow vnet-enabled jails) and have experienced no problems over the past couple weeks.

I'm adding a diff to make this the default keyword, and would love to hear any concerns anyone might have.

[0]https://cgit.freebsd.org/ports/commit/?id=c7e6df59748cd15ebea3c4e83e7f3bcdda529879
Comment 1 Dries Michiels freebsd_committer freebsd_triage 2021-08-31 18:09:24 UTC 
Was planning to take this in with the 9.4.1 update, but doesn't matter my local change looks identically.
Comment 2 Dries Michiels freebsd_committer freebsd_triage 2021-11-09 15:44:53 UTC 
Take.

Would you like credit for your contribution, i.e. can I use your name and e-mail as author of the change?
Comment 3 Lucas Toole 2021-11-10 19:15:28 UTC 
(In reply to Dries Michiels from comment #2)
Sure! That sounds great!
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-11-13 16:06:58 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=128e4bb46e8d4d66f3c48c22354e19de6b5947b6

commit 128e4bb46e8d4d66f3c48c22354e19de6b5947b6
Author:     Lucas Toole <lucas@ltoole.com>
AuthorDate: 2021-11-09 15:40:11 +0000
Commit:     Dries Michiels <driesm@FreeBSD.org>
CommitDate: 2021-11-13 16:06:23 +0000

    net/dhcpcd: Switch keyword from nojail to nojailvnet in rc script

    The keyword was added in 2007 following git history, c7e6df59748c. This
    is a remnant of the pre-VNET days. dhcpcd is perfectly capable of
    running in a VNET jail so relax keyword. This allows dhcpcd to start in
    a VNET jail.

    PR:                     258185
    Approved by:            0mp (mentor), philip (mentor)
    Differential Revision:  https://reviews.freebsd.org/D32959

 net/dhcpcd/Makefile        | 2 +-
 net/dhcpcd/files/dhcpcd.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 5 Dries Michiels freebsd_committer freebsd_triage 2021-11-13 16:10:31 UTC 
Committed, thanks for the patch!