Bug 258234 - editors/vim: python option not enabling python3interp
Summary: editors/vim: python option not enabling python3interp
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-02 23:30 UTC by Derek Schrock
Modified: 2021-09-03 07:13 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (adamw)

Attachments
Pass python3 configure args (874 bytes, patch)
2021-09-02 23:30 UTC, Derek Schrock 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Derek Schrock 2021-09-02 23:30:25 UTC 
Created attachment 227629 [details]
Pass python3 configure args

OPT_CONFIGURE_ARGS isn't part of the options framework.  Use ..._ENABLE and ..._WITH.

Pre-patch

  --CONFIGURE_ARGS--
  --disable-canberra  --enable-cscope  --enable-gui=  --enable-multibyte  --with-  tlib=ncursesw --disable-luainterp --without-lua-prefix --enable-nls --disable-perlinterp --disable-rubyinterp --disable-mzschemeinterp --disable-tclinterp --without-tclsh --prefix=/usr/local ${_LATE_CONFIGURE_ARGS}
  --End CONFIGURE_ARGS--

  $ pkg info -i vim
  vim-8.2.3394

  $ pkg info -f vim | fgrep PYTHON
          PYTHON         : on

  $ vim --version | fgrep python3
  +cmdline_info      +libcall           -python3           +visualextra

  configure phase:
  ...
  checking --enable-python3interp argument... no
  ...


Post-update:

  ...
  checking --enable-python3interp argument... yes
  checking --with-python3-command argument... /usr/local/bin/python3.8
  checking Python version... 3.8
  ...

  $ vim --version | fgrep \+python3
  +cmdline_info      +libcall           +python3           +visualextra
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-09-03 07:12:38 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a6a9141dbc9cee3dee286ccf934980bd1e071177

commit a6a9141dbc9cee3dee286ccf934980bd1e071177
Author:     Derek Schrock <dereks@lifeofadishwasher.com>
AuthorDate: 2021-09-03 07:11:05 +0000
Commit:     Adam Weinberger <adamw@FreeBSD.org>
CommitDate: 2021-09-03 07:11:05 +0000

    editors/vim: Fix python language bindings

    PR:             258234

 editors/vim/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 2 Adam Weinberger freebsd_committer freebsd_triage 2021-09-03 07:13:32 UTC 
Thanks, Derek. Not sure how I missed that copy-paste braino.