Bug 258345 - net/libwebsockets: Fix building with LibreSSL
Summary: net/libwebsockets: Fix building with LibreSSL
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-07 17:34 UTC by Robert Kruus
Modified: 2021-12-08 10:51 UTC (History)
1 user (show)

See Also:

Attachments
Force use of libressl libs/includes in build if required. (512 bytes, text/plain)
2021-09-07 17:34 UTC, Robert Kruus 		no flags Details
Patch for libwebsockets (1.34 KB, patch)
2021-10-05 07:59 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Kruus 2021-09-07 17:34:59 UTC 
Created attachment 227740 [details]
Force use of libressl libs/includes in build if required.

If libressl is defined as default in make.conf (ssl=libressl), the build uses both the base ssl and LibreSSL.
The port builds fine without this, but linking against generated libs causes confusion.

The build can be forced to build only against the LibreSSL libs and includes. This patch links against LibreSSL dynamic libs, but can also use static libs (change .so to .a).
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2021-09-07 17:34:59 UTC 
Maintainer informed via mail
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2021-10-05 07:59:10 UTC 
Created attachment 228453 [details]
Patch for libwebsockets

Bump libwebsockets and add LibreSSL "hack"
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2021-10-05 08:00:11 UTC 
Hi Rob,

I apologize for the wait, can you give this a try and report back?
Please also include what version of FreeBSD and arch you're testing it on.

Best regards,
Daniel
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-12-08 10:50:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ab8391bc3c2ef4a419b5275f75c10690dbfda2de

commit ab8391bc3c2ef4a419b5275f75c10690dbfda2de
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2021-12-08 10:29:19 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2021-12-08 10:48:52 +0000

    net/libwebsockets: Update to 4.2.2

    Changelog: https://github.com/warmcat/libwebsockets/compare/v4.2.1...v4.2.2
    Add support for LibreSSL - Submitted by Rob Kruus
    Reset maintainer due to multiple timeouts

    PR:             258345
    Approved by:    mentors (implicit), maintainer timeout (3 months)

 net/libwebsockets/Makefile | 11 +++++++++--
 net/libwebsockets/distinfo |  6 +++---
 2 files changed, 12 insertions(+), 5 deletions(-)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2021-12-08 10:51:45 UTC 
Committed, thanks!