Bug 258402 - security/openssh-portable: link fail with WITHOUT_LIBEDIT
Summary: security/openssh-portable: link fail with WITHOUT_LIBEDIT
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-10 12:21 UTC by Ivan Rozhuk
Modified: 2021-09-10 17:48 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (bdrewery)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2021-09-10 12:21:02 UTC 
...
cc -o scp scp.o progressmeter.o sftp-common.o sftp-client.o sftp-glob.o -L. -Lopenbsd-compat/ -L/usr/local/lib  -Wl,-rpath,/usr/local/lib -fstack-protector-strong  -Wl,-z,retpolineplt -Wl,-z,relro -Wl,-z,now -Wl,-z,noexecstack -fstack-protector-strong -lssh -lopenbsd-compat -lcrypto -lutil -lz -L/usr/local/lib -lcrypt
--- ssh-sk-helper ---
cc -o ssh-sk-helper ssh-sk-helper.o ssh-sk.o sk-usbhid.o -L. -Lopenbsd-compat/ -L/usr/local/lib  -Wl,-rpath,/usr/local/lib -fstack-protector-strong  -Wl,-z,retpolineplt -Wl,-z,relro -Wl,-z,now -Wl,-z,noexecstack -fstack-protector-strong -lssh -lopenbsd-compat -lssh -lopenbsd-compat -lcrypto -lutil -lz -L/usr/local/lib -lcrypt 
--- sftp.o ---
sftp.c:257:1: error: unused function 'read_interrupt' [-Werror,-Wunused-function]
read_interrupt(int signo)
^
1 error generated.
*** [sftp.o] Error code 1


OPTIONS_FILE_UNSET+=BLACKLISTD
OPTIONS_FILE_UNSET+=BSM
OPTIONS_FILE_UNSET+=DOCS
OPTIONS_FILE_UNSET+=FIDO_U2F
OPTIONS_FILE_UNSET+=HPN
OPTIONS_FILE_UNSET+=KERB_GSSAPI
OPTIONS_FILE_UNSET+=LDNS
OPTIONS_FILE_UNSET+=LIBEDIT
OPTIONS_FILE_UNSET+=NONECIPHER
OPTIONS_FILE_SET+=PAM
OPTIONS_FILE_UNSET+=TCP_WRAPPERS
OPTIONS_FILE_UNSET+=XMSS
OPTIONS_FILE_UNSET+=MIT
OPTIONS_FILE_UNSET+=HEIMDAL
OPTIONS_FILE_UNSET+=HEIMDAL_BASE
Comment 1 Bryan Drewery freebsd_committer freebsd_triage 2021-09-10 17:48:27 UTC 
Fixed. Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-09-10 17:48:51 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d27003d5644902b91d86ff3f0c36d7b8c56710f0

commit d27003d5644902b91d86ff3f0c36d7b8c56710f0
Author:     Bryan Drewery <bdrewery@FreeBSD.org>
AuthorDate: 2021-09-10 17:46:02 +0000
Commit:     Bryan Drewery <bdrewery@FreeBSD.org>
CommitDate: 2021-09-10 17:48:05 +0000

    security/openssh-portable: Various build fixes

    - Fix build with WITH_BLACKLISTD [1]
    - Fix build with WITHOUT_LIBEDIT due to upstream bug [2]

    Reported by:    emaste [1]
    Reported by:    Ivan Rozhuk [2]
    PR:             258402 [2]

 security/openssh-portable/files/extra-patch-blacklistd | 10 +++++-----
 security/openssh-portable/files/patch-sftp.c (new)     | 17 +++++++++++++++++
 2 files changed, 22 insertions(+), 5 deletions(-)