Bug 258582 - emulators/winetricks package message about 32-bit
Summary: emulators/winetricks package message about 32-bit
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kevin Bowling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-18 18:06 UTC by Graham Perrin
Modified: 2021-09-22 17:10 UTC (History)
2 users (show)

See Also:
Alexander88207: maintainer-feedback+

Attachments
winetricks-patch-258582.diff (886 bytes, patch)
2021-09-18 23:52 UTC, Alexander Vereeken 		Alexander88207: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin freebsd_committer freebsd_triage 2021-09-18 18:06:45 UTC 
> … requires a 32 bit version of Wine …

– et cetera, maybe outdated. 

I'm running winetricks (successfully) in this environment: 

% pkg info -x wine
wine-6.0.1_2,1
wine-proton-6.3.2_2
winetricks-20210825
% uname -aKU
FreeBSD mowa219-gjp4-8570p-freebsd 14.0-CURRENT FreeBSD 14.0-CURRENT #109 main-n249408-ff33e5c83fa: Thu Sep 16 01:11:04  2021     root@mowa219-gjp4-8570p-freebsd:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG  amd64 1400033 1400033
%
Comment 1 Alexander Vereeken freebsd_triage 2021-09-18 23:52:47 UTC 
Created attachment 227996 [details]
winetricks-patch-258582.diff

Hello Graham,

you are right and thank you for your report.

Removing the message entirely and while here setting Arch only for i386 and amd64.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-09-22 17:09:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0c37d65105e9a490d7231304a1bce1536ff1a5fd

commit 0c37d65105e9a490d7231304a1bce1536ff1a5fd
Author:     Alexander Vereeken <Alexander88207@protonmail.com>
AuthorDate: 2021-09-22 17:07:10 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2021-09-22 17:08:42 +0000

    emulators/winetricks: Mark only for archs amd64/i386

    PR:             258582
    Reported by:    Graham Perrin <grahamperrin@gmail.com>

 emulators/winetricks/Makefile           |  3 +++
 emulators/winetricks/pkg-message (gone) | 11 -----------
 2 files changed, 3 insertions(+), 11 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-09-22 17:10:32 UTC 
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=36d264034a3281d1eff08b9bc8ad756086ef4669

commit 36d264034a3281d1eff08b9bc8ad756086ef4669
Author:     Alexander Vereeken <Alexander88207@protonmail.com>
AuthorDate: 2021-09-22 17:07:10 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2021-09-22 17:09:39 +0000

    emulators/winetricks: Mark only for archs amd64/i386

    PR:             258582
    Reported by:    Graham Perrin <grahamperrin@gmail.com>

    (cherry picked from commit 0c37d65105e9a490d7231304a1bce1536ff1a5fd)

 emulators/winetricks/Makefile           |  3 +++
 emulators/winetricks/pkg-message (gone) | 11 -----------
 2 files changed, 3 insertions(+), 11 deletions(-)
Comment 4 Kevin Bowling freebsd_committer freebsd_triage 2021-09-22 17:10:53 UTC 
Thanks for the report and patch!