Bug 258627 - devel/subversion remove FREEBSD_TEMPLATE from defaults
Summary: devel/subversion remove FREEBSD_TEMPLATE from defaults
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Lev A. Serebryakov
URL:
Keywords:
: 263422 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-09-20 12:19 UTC by D'Arcy J.M. Cain
Modified: 2022-04-19 19:16 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (lev)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description D'Arcy J.M. Cain 2021-09-20 12:19:58 UTC 
As discussed in the ports mailing list:

Or at least not make it the default.  I have never understood why this
was the default anyway.  FreeBSD committers will most likely build from
source and can add that flag if they want.  As default it becomes the
option for people installing from packages and they can't remove that
template for all of their non-FreeBSD work.  Now that we have switched
to git it seems even more so that it should not be the default.

diff --git a/devel/subversion/Makefile b/devel/subversion/Makefile
index 5df5175b25a8..2841c92b9c09 100644
--- a/devel/subversion/Makefile
+++ b/devel/subversion/Makefile
@@ -26,7 +26,7 @@ OPTIONS_DEFINE=       \
                TEST            \
                TOOLS
 
-OPTIONS_DEFAULT=FREEBSD_TEMPLATE GPG_AGENT SERF TOOLS
+OPTIONS_DEFAULT=GPG_AGENT SERF TOOLS
 
 FREEBSD_TEMPLATE_DESC= FreeBSD Project log template
 GPG_AGENT_DESC=                Enable GPG agent password store
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-04-14 11:23:38 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3e88f1fdba33034989bbc390503bb2e18275a538

commit 3e88f1fdba33034989bbc390503bb2e18275a538
Author:     Lev A. Serebryakov <lev@FreeBSD.org>
AuthorDate: 2022-04-14 11:22:24 +0000
Commit:     Lev A. Serebryakov <lev@FreeBSD.org>
CommitDate: 2022-04-14 11:22:24 +0000

    devel/subversion: Turn off FREEBSD_TEMPLATE by default.

      As now subversion is not used for FreeBSD development, have this option
    turned on by default has little sense.

    PR:     258627

 devel/subversion/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-04-14 11:23:39 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=213ca78238f0fc5290e4132339e8c80db25a6663

commit 213ca78238f0fc5290e4132339e8c80db25a6663
Author:     Lev A. Serebryakov <lev@FreeBSD.org>
AuthorDate: 2022-04-14 11:20:55 +0000
Commit:     Lev A. Serebryakov <lev@FreeBSD.org>
CommitDate: 2022-04-14 11:20:55 +0000

    devel/subversion-lts: Turn off FREEBSD_TEMPLATE by default.

      As now subversion is not used for FreeBSD development, have this option
    turned on by default has little sense.

    PR:     258627

 devel/subversion-lts/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 3 Lev A. Serebryakov freebsd_committer freebsd_triage 2022-04-14 11:24:09 UTC 
Committed, thanx!
Comment 4 Lev A. Serebryakov freebsd_committer freebsd_triage 2022-04-19 19:16:37 UTC 
*** Bug 263422 has been marked as a duplicate of this bug. ***