Bug 258775 - sysutils/arcconf: [PATCH] do not depend on compat12x for FreeBSD-12.2
Summary: sysutils/arcconf: [PATCH] do not depend on compat12x for FreeBSD-12.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-29 09:58 UTC by Palle Girgensohn
Modified: 2021-10-11 11:41 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (michael)

Attachments
arcconf patch (427 bytes, patch)
2021-09-29 09:58 UTC, Palle Girgensohn 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Palle Girgensohn freebsd_committer freebsd_triage 2021-09-29 09:58:49 UTC 
Created attachment 228241 [details]
arcconf patch

arcconf fails to build on 12.2 since compat12x cannot be installed on FreeBSD-12.2.

Make sure we depend on compat12x only for later versions of the OS.
Comment 1 Palle Girgensohn freebsd_committer freebsd_triage 2021-09-29 10:14:34 UTC 
===========================================================================
=>> Checking for filesystem violations... done
=======================<phase: run-depends    >============================
===>   arcconf-3.07.23971,1 depends on file: /usr/local/lib/compat/libncurses.so.8 - not found
===>   arcconf-3.07.23971,1 depends on package: /packages/All/compat12x-amd64-12.2.1202000.20210406.pkg - not found
===>   USE_PACKAGE_DEPENDS_ONLY set - not building missing dependency from source
*** Error code 1

Stop.
make: stopped in /usr/ports/sysutils/arcconf
build of sysutils/arcconf | arcconf-3.07.23971,1 ended at Wed Sep 29 12:13:32 CEST 2021
build time: 00:00:17
!!! build failure encountered !!!
[00:00:25] Error: Build failed in phase: run-depends
[00:00:25] Cleaning up
122-amd64-git: removed
122-amd64-git-n: removed
[00:00:25] Unmounting file systems
Comment 2 Palle Girgensohn freebsd_committer freebsd_triage 2021-09-29 10:15:57 UTC 
so, this may be only a poudriere issue, but I still think we shouldn't depend on compat12x for FreeBSD-12.x
Comment 3 michael 2021-10-07 20:00:01 UTC 
looks good, please commit
Comment 4 rainer 2021-10-08 07:44:12 UTC 
Please also MFH to 2021Q4.

I actually have a server with such a card (and 12.2).
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-10-11 11:35:33 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1ad8cfa1e9c41bebe77fa8d1cc73ad627613883b

commit 1ad8cfa1e9c41bebe77fa8d1cc73ad627613883b
Author:     Palle Girgensohn <girgen@FreeBSD.org>
AuthorDate: 2021-10-08 07:57:40 +0000
Commit:     Palle Girgensohn <girgen@FreeBSD.org>
CommitDate: 2021-10-11 11:35:00 +0000

    sysutils/arcconf: only depend on compat12x for FreeBSD > 12

    PR:     258775

 sysutils/arcconf/Makefile | 3 +++
 1 file changed, 3 insertions(+)
Comment 6 Palle Girgensohn freebsd_committer freebsd_triage 2021-10-11 11:41:23 UTC 
Committed and MFH:ed.
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-10-11 11:41:35 UTC 
A commit in branch 2021Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=05ede39babf288b59a0a5d8d7b50b284d5dc20c3

commit 05ede39babf288b59a0a5d8d7b50b284d5dc20c3
Author:     Palle Girgensohn <girgen@FreeBSD.org>
AuthorDate: 2021-10-08 07:57:40 +0000
Commit:     Palle Girgensohn <girgen@FreeBSD.org>
CommitDate: 2021-10-11 11:40:39 +0000

    sysutils/arcconf: only depend on compat12x for FreeBSD > 12

    PR:     258775
    (cherry picked from commit 1ad8cfa1e9c41bebe77fa8d1cc73ad627613883b)

 sysutils/arcconf/Makefile | 3 +++
 1 file changed, 3 insertions(+)