Bug 258837 - www/firefox: unbreak llvm=13 build
Summary: www/firefox: unbreak llvm=13 build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gecko (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-10-01 10:56 UTC by Evgenii Khramtsov
Modified: 2021-10-02 00:17 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gecko)

Attachments
v1 (use "git am") (2.13 KB, patch)
2021-10-01 10:56 UTC, Evgenii Khramtsov 		2khramtsov: maintainer-approval? (gecko)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Evgenii Khramtsov 2021-10-01 10:56:33 UTC 
Created attachment 228314 [details]
v1 (use "git am")

Restore patch-bug1628567 to unbreak glslopt crate build due to cc crate
passing Rust target "x86_64-unknown-freebsd" without OS version to clang++:

[glslopt 0.1.9] cargo:warning=/wrkdirs/usr/ports/www/firefox/work/.build/
ist/system_wrappers/new:3:15: fatal error: 'new' file not found
[glslopt 0.1.9] cargo:warning=#include_next <new>

Build passed on 12.2/amd64 jail with this patch (llvm=13 and llvm=12) and without (llvm=12). Also, build still passes after forced LTO with llvm=13 via reverting ports 4e67118c7.

Note, ports llvm still uses base libc++ (bug 215193), so this helps bug 258209 only partly. Upstream bug 1731582 patches might be needed for in base libc++ 13:
https://bugzilla.mozilla.org/show_bug.cgi?id=1731582
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-10-02 00:11:52 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dcc587e70268eb898aecad53ab9d08ea50e0bbab

commit dcc587e70268eb898aecad53ab9d08ea50e0bbab
Author:     Evgeniy Khramtsov <evgeniy@khramtsov.org>
AuthorDate: 2021-09-30 22:34:51 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-10-02 00:10:14 +0000

    www/firefox: unbreak build with devel/llvm13 (lacks patch-D77776)

    Restore patch-bug1628567 to unbreak glslopt crate build due to cc crate
    passing Rust target "x86_64-unknown-freebsd" without OS version to clang++:

    [glslopt 0.1.9] cargo:warning=/wrkdirs/usr/ports/www/firefox/work/.build/
    ist/system_wrappers/new:3:15: fatal error: 'new' file not found
    [glslopt 0.1.9] cargo:warning=#include_next <new>

    PR:             258837

 www/firefox/files/patch-bug1628567 (new) | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-10-02 00:13:53 UTC 
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b7f6e0701703f1efbedf5f92a02eed7c3aa7bbe9

commit b7f6e0701703f1efbedf5f92a02eed7c3aa7bbe9
Author:     Evgeniy Khramtsov <evgeniy@khramtsov.org>
AuthorDate: 2021-09-30 22:34:51 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-10-02 00:12:08 +0000

    www/firefox: unbreak build with devel/llvm13 (lacks patch-D77776)

    Restore patch-bug1628567 to unbreak glslopt crate build due to cc crate
    passing Rust target "x86_64-unknown-freebsd" without OS version to clang++:

    [glslopt 0.1.9] cargo:warning=/wrkdirs/usr/ports/www/firefox/work/.build/
    ist/system_wrappers/new:3:15: fatal error: 'new' file not found
    [glslopt 0.1.9] cargo:warning=#include_next <new>

    PR:             258837
    (cherry picked from commit dcc587e70268eb898aecad53ab9d08ea50e0bbab)

 www/firefox/files/patch-bug1628567 (new) | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)