Bug 258864 - sysutils/rundeck3 Update to 3.4.4
Summary: sysutils/rundeck3 Update to 3.4.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Daniel Engberg
URL: https://docs.rundeck.com/docs/history...
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2021-10-02 10:33 UTC by Daniel Tihanyi
Modified: 2021-10-08 07:18 UTC (History)
2 users (show)

See Also:


Attachments
Rundeck 3.4.4 Update diff (1.76 KB, patch)
2021-10-02 10:33 UTC, Daniel Tihanyi
daniel.tihanyi: maintainer-approval+
Details | Diff
Rundeck 3.4.4 Update diff v2 (1.27 KB, patch)
2021-10-05 13:54 UTC, Daniel Tihanyi
daniel.tihanyi: maintainer-approval+
Details | Diff
Rundeck 3.4.4 Update diff v3 (1.20 KB, patch)
2021-10-05 14:05 UTC, Daniel Tihanyi
daniel.tihanyi: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Tihanyi 2021-10-02 10:33:04 UTC
Created attachment 228352 [details]
Rundeck 3.4.4 Update diff

This is an update to Rundeck 3.4.4.
Release notes for 3.4.4: https://docs.rundeck.com/docs/history/3_4_x/version-3.4.4.html
Also:
  - MASTER_SITES change, as bintray is shut down
  - Added DISTFILES variable as the file name to be downloaded changed to "download"
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-10-05 00:34:05 UTC
This is a no go and will clash with newer versions

MASTER_SITES= https://packagecloud.io/pagerduty/rundeck/packages/java/org.rundeck/rundeck-3.4.4-20210920.war/artifacts/rundeck-3.4.4-20210920.war/download?/ seems to do what you want without defining DISTFILES?
Comment 2 Daniel Tihanyi 2021-10-05 13:54:46 UTC
Created attachment 228461 [details]
Rundeck 3.4.4 Update diff v2

Hello Daniel,
thank you very much for taking your time and having a look at this patch.
Indeed, the download works fine with your suggestion, the file will be created with it's correct name. I modified the diff and uploaded the new, reflecting this.
Ps.: Should I also add the flag "maintainer-approval +" for patches I create?
Thank you!
Comment 3 Daniel Tihanyi 2021-10-05 14:05:41 UTC
Created attachment 228463 [details]
Rundeck 3.4.4 Update diff v3

One small change, use DISTNAME in MASTER_SITES instead of defining it again.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2021-10-05 23:50:15 UTC
^Triage: Needs Assignee before In Progress, assign to committer resolving
(improve SNR on mailing lists).
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-10-08 07:07:56 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b14f3ee01364f33634f02e2519a17c4b7fe22080

commit b14f3ee01364f33634f02e2519a17c4b7fe22080
Author:     Daniel Tihanyi <daniel.tihanyi@tetragir.com>
AuthorDate: 2021-10-08 06:20:29 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2021-10-08 07:06:34 +0000

    sysutils/rundeck3: Update to 3.4.4

    Changelog: https://docs.rundeck.com/docs/history/3_4_x/version-3.4.4.html

    PR:             258864
    Approved by:    arrowd (mentor)
    Differential Revision:  https://reviews.freebsd.org/D32326

 sysutils/rundeck3/Makefile | 7 +++----
 sysutils/rundeck3/distinfo | 6 +++---
 2 files changed, 6 insertions(+), 7 deletions(-)
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2021-10-08 07:18:01 UTC
Committed, thanks!