Created attachment 228585 [details] Proposed patch Logins fail with glib > 2.68 because of a change to the return value of g_match_info_fetch(). This patch cherry-picks upstream's fix for that issue.
Upstream issue: https://github.com/sm00th/bitlbee-discord/issues/226
(In reply to Corey Halpin from comment #0) Hi. As the maintainer, just giving a status update. I'll get to this in the next day or two. However, I'm thinking of dropping maintainership for this port in the near future, as I realized I haven't used bitlbee-discord in some time. It also seems your proposed patch is in upstream now, so I'll pull from that. Thanks, arfy
Excellent thank you! I'd be willing to assume maintainership if you no longer want it. For what it's worth, pulling from upstream is exactly how I generated `patch-607f9887.patch`. It was created with `curl https://github.com/sm00th/bitlbee-discord/commit/607f9887ca85f246e970778e3d40aa5c346365a7.patch -o patch-607f9887.patch`.
(gentle bump)
Hi. I actually submitted a bug for this a few weeks back. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259257 Not sure if I need to do something else now.
Ah, I see. It would have been good to include a note on that bug linking to this one so that when a committer takes care of the other one they can also close this as obsolete. Also, if I'd known about the other bug I could also have tested your patch and chimed in over there to indicate if it works for me. I shall do that later today (after the `poudriere bulk` run that I just started finishes). Here are the instructions for doing port updates via Bugzilla: https://wiki.freebsd.org/Bugzilla/ThePerfectPortsIssue I would guess that the main reason no committer has looked at this yet is that the 'maintainer approval' flag on the patch is not set to '+', which prevents this bug from showing up in the searchers that committers use to locate bugs they need to take action on.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=637e1d7c317ebbec1d10c429142ec8c00a236a11 commit 637e1d7c317ebbec1d10c429142ec8c00a236a11 Author: Arthur Pirika <arfy32@gmail.com> AuthorDate: 2021-12-07 02:59:09 +0000 Commit: Hiroki Tagato <tagattie@FreeBSD.org> CommitDate: 2021-12-07 03:02:05 +0000 irc/bitlbee-discord: fix issue with glib >= 2.69 PR: 259072, 259257 Reported by: Corey Halpin <chalpin@cs.wisc.edu>, Arthur Pirika <arfy32@gmail.com> (maintainer) MFH: 2021Q4 (bug fix) irc/bitlbee-discord/Makefile | 3 ++- irc/bitlbee-discord/distinfo | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-)
A commit in branch 2021Q4 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a9040fc6c24e6776afc8d4742a1ce5a1fbed95e4 commit a9040fc6c24e6776afc8d4742a1ce5a1fbed95e4 Author: Arthur Pirika <arfy32@gmail.com> AuthorDate: 2021-12-07 02:59:09 +0000 Commit: Hiroki Tagato <tagattie@FreeBSD.org> CommitDate: 2021-12-07 03:04:53 +0000 irc/bitlbee-discord: fix issue with glib >= 2.69 PR: 259072, 259257 Reported by: Corey Halpin <chalpin@cs.wisc.edu>, Arthur Pirika <arfy32@gmail.com> (maintainer) MFH: 2021Q4 (bug fix) (cherry picked from commit 637e1d7c317ebbec1d10c429142ec8c00a236a11) irc/bitlbee-discord/Makefile | 3 ++- irc/bitlbee-discord/distinfo | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-)
This issue is related with bug 259257 which is resolved and closed. Closing this issue as well. Thanks for your contribution.