Created attachment 228643 [details] update darkplaces to 20180908beta1 There is an HTML index at http://icculus.org/twilight/darkplaces/files/ (MASTER_SITES), and this is the most recent version I found in the list. Two patches are removed because corresponding code does not exist anymore and there does not seem to be any equivalent.
Interesting. There are several substantial changes, like removed per-platform clients (wgl/glx/agl), now only SDL2 client exists. Also, dedicated server is broken in the latest beta (but works in e.g. 20160717 one), I'd have to bisect what went wrong. Overall, this update would require quite some testing before landing in the ports tree, esp. given that current port works fine (both GLX client, which I use, and dedicated server).
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b05652e4adc416ebf6ca4b0d38199373376ca123 commit b05652e4adc416ebf6ca4b0d38199373376ca123 Author: Alexey Dokuchaev <danfe@FreeBSD.org> AuthorDate: 2021-12-01 16:56:42 +0000 Commit: Alexey Dokuchaev <danfe@FreeBSD.org> CommitDate: 2021-12-01 16:56:43 +0000 games/darkplaces: the port had been updated and cleaned up (+) - Update to 20180412beta1 penultimate snapshot, the very latest one had introduced too many changes which e.g. broke dedicated server - Drop needless zip:infozip dependency, set USE_XORG more discretely - Follow the defaults and link to libjpeg the usual way rather than load it at run-time with dlopen(3) - Target `sdl-release' is spelled the same, regardless of the used SDL version - Remove SSE port option: upstream makefile logic enables it for x86 CPUs; it's safe to assume that all modern x86 CPUs would support these instructions - Amend patches and remove `post-patch' target (patching makefiles for LOCALBASE with sed(1) is bogus in the first place as it is passed on the MAKE_ENV and thus propagated down to inner makes) - Do not try to use unsupported `-fno-signaling-nans' compiler flag - Define LICENSE (GPLv2 or later) and assume port's maintainership PR: 259123 games/darkplaces/Makefile | 41 +++++++++------------------- games/darkplaces/distinfo | 5 ++-- games/darkplaces/files/patch-makefile (new) | 20 ++++++++++++++ games/darkplaces/files/patch-makefile.inc | 42 ++++++++++++++++++++++++++--- 4 files changed, 75 insertions(+), 33 deletions(-)
(In reply to Alexey Dokuchaev from comment #1) > Also, dedicated server is broken in the latest beta This patch[1] fixes the crash, but there are some other minor issues that still need ironing out. Debian package[2] includes quite a few patches which we might want to include in our port as well. [1] http://svn.icculus.org/twilight?view=rev&revision=12469 [2] http://ports.ubuntu.com/ubuntu-ports/pool/universe/d/darkplaces/darkplaces_0~20180908~beta1-4.debian.tar.xz
Comment on attachment 228643 [details] update darkplaces to 20180908beta1 Thank you very much for the update. Seeing your work, I'm a bit ashamed of the patch I provided :-) I think I originally did the update because I had some issues with high resolution texture packs, and wanted to see if it solved it (I don't remember). Then forgot about it for some time, and later thought that people may be interested to see that. I'll try to test your update in a few day, and maybe (not sure at all) look at the patches you mentioned. Thanks again!
Friendly Reminder.
I tested the port after it was updated (patch from comment #2) and again a few days ago. Each time I completed a few maps of the first episodes, but I didn't use the dedicated server. I will close the PR because I'm happy with this update. I was not sure if I should have closed it at the time, if we wanted to do more work (about the patch listed in comment #3). But this info is not lost and I guess we could open a new PR later. Thank you very much.