Created attachment 228785 [details] Diff for changes in devel/coursier for new version and structure The current version of coursier on ports is 1.1.0-M12. There have been many changes with the project since then. This diff updates not only the version to the latest stable version of coursier (needed for Scala users that use Metals, the Scala language server), and it also updates the way it extracts the artifact. Previously it was grabbing source and taking the coursier executable from the root. That project structure has changed, so that's no longer possible. I instead followed a similar approach to what shells/ammonite does and instead grab the coursier executable from the releases. There has also been a lot of new features added, which is the reason for the pkg-descr change. I've followed the testing steps in the porters-handbook, everything works, and I believe I have the diff all set to go. This is my first time submitting to ports, so please let me know if there is something else needed.
The way your distfile is set up, the name does not change when upstream releases a new version. This is a bad thing as it means the FreeBSD distfile cache will be unable to cache more than one version of the distfile. The easiest way to fix this is to set DIST_SUBDIR to something like DIST_SUBDIR= ${PORTNAME}-${DISTVERSION} so each version of the distfile gets its own directory.
Created attachment 229077 [details] Updated diff to account for new structure and version of coursier
(In reply to Robert Clausecker from comment #1) Gotcha that makes sense. I went ahead and made that change. Thanks!
You can set the maintainer-approval flag to + with reason "maintainer timeout." Apparently the maintainer truly doesn't care about this one. Is the patch still current?
Is this still the most current version? The maintainer seems to be AWOL, so I'll be able to commit your patch as is once it passes testing.
Return to pool due to a lack of submitter response.
Created attachment 249735 [details] Patch to update devel/coursier to 2.1.9 Hi, I've adjusted the former patch to the current version of coursier. Providing the changelog doesn't make sense IMHO because of the sheer size of it. Kind regards, Jens
Hi, could we move this forward? I'm using the locally built package on several machines without issues. Kind regards, Jens
I'm sorry for the delay. We can proceed without maintainer approval as the maintainer has not responded. Unfortunately I am scheduled for surgery on Monday and will be unable to process ports PRs for the next week or two.
(In reply to Robert Clausecker from comment #9) Best wishes and a good recovery! Kind regards.
Patch looks good. I'll remove the now no-op DOCS option on commit. Would you like to take up maintainership over this port?
Other changes I'll make on commit: - I'll extract to WRKDIR so we don't need WRKSRC - the script will be patched to obey ${JAVA} for the Java interpreter
(In reply to Robert Clausecker from comment #11) Thanks and yes I can take over maintainership for this port. Kind regards
Please change DIST_SUBDIR= ${PORTNAME}-${DISTVERSION} to DIST_SUBDIR= ${PORTNAME}/${DISTVERSION} we don't need a new directory in root of distfiles for each release
Created attachment 251501 [details] Patch to update devel/coursier to 2.1.9 - changed DIST_SUBDIR to ${PORTNAME}/${DISTVERSION} - remove obsolete DOC option
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=876b8bb7bac8ccb5a028b8635decf8b14f789a2f commit 876b8bb7bac8ccb5a028b8635decf8b14f789a2f Author: Jens Grassel <jens@wegtam.com> AuthorDate: 2024-04-05 08:43:52 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2024-06-16 11:53:29 +0000 devel/coursier: Update to version 2.1.9 - submitter becomes maintainer - make script obey ${JAVA} - remove obsolete DOCS option Changelog: https://github.com/coursier/coursier/releases PR: 259233 Approved by: Chris <chris@chris-kipp.io> (maintainer timeout) Reviewed by: diizzy devel/coursier/Makefile | 23 ++++++++++++----------- devel/coursier/distinfo | 6 +++--- devel/coursier/pkg-descr | 6 ++++-- 3 files changed, 19 insertions(+), 16 deletions(-)
Thank you for your submission.
Hi, I get pkg-fallout mails now stating => coursier/2.1.9/coursier is not in /usr/ports/devel/coursier/distinfo. => Either /usr/ports/devel/coursier/distinfo is out of date, or => coursier/2.1.9/coursier is spelled incorrectly. however I can build the port and package totally fine locally using the current git branch of the ports tree. Any ideas or should I create another ticket? Kind regards,
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=fd68fde0f58b447740f857bede6f1e6992ffeca8 commit fd68fde0f58b447740f857bede6f1e6992ffeca8 Author: Robert Clausecker <fuz@FreeBSD.org> AuthorDate: 2024-06-18 16:41:03 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2024-06-18 16:41:03 +0000 devel/coursier: update distinfo I forgot to do this when applying diizzy's recommendations. Fixes: 876b8bb7bac8ccb5a028b8635decf8b14f789a2f PR: 259233 devel/coursier/distinfo | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Sorry, there was a copy-editing error when I applied diizzy's recommendations. Should be fixed now, thanks for letting me know!