Created attachment 228802 [details] "git diff" to update the port - Update 1.56 --> 1.57 (bugfix release) Changes: https://metacpan.org/release/JONASBN/Workflow-1.57/source/Changes.md - "portlint -AC" gives non-relevant warns. - "portclippy Makefile" is happy. - "portfmt -D Makefile" is happy. - Tested with: 13.0-RELEASE-p4 pkg 1.17.2 poudriere 3.3.7_1 perl 5.32.1_1 openssl 1.1.1k ssl=base - built-in perl tests in a clean poudriere jail say: PASS.
Hello, Use DISTVERSION instead of PORTVERSION: --- Example 2. Using DISTVERSION When the version only contains numbers separated by dots, dashes or underscores, use DISTVERSION. --- https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-naming Cheers
Created attachment 228807 [details] "git diff" to update the port
(In reply to Nuno Teixeira from comment #1) Hi Nuno, Yes, please find a new patch. But do you think that maybe portlint, portclippy, portfmt or such should monitor this DISTVERSION vs PORTVERSION issue automatically? Regards, Sergei
Hello, Well those tools are just for helping porters and maintainers to fine tune ports and e never follow them blindly. Porter's Handbook is very important as it explain the best pratices to use. Cheers
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=460f534008b66f8fc11ba8aeead518f70de3a526 commit 460f534008b66f8fc11ba8aeead518f70de3a526 Author: Sergei Vyshenski <svysh.fbsd@gmail.com> AuthorDate: 2021-10-18 16:40:04 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2021-10-18 16:41:38 +0000 devel/p5-Workflow: Update to 1.57 ChangeLog: https://metacpan.org/release/JONASBN/Workflow-1.57/source/Changes.md PR: 259245 devel/p5-Workflow/Makefile | 10 +++++----- devel/p5-Workflow/distinfo | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-)
Committed thanks!