Bug 259331 - devel/doxygen: Fix build with MAKE_JOBS
Summary: devel/doxygen: Fix build with MAKE_JOBS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthias Andree
URL:
Keywords: needs-qa, performance
Depends on:
Blocks: 279330
  Show dependency treegraph
 
Reported: 2021-10-21 04:26 UTC by Tatsuki Makino
Modified: 2025-01-11 10:31 UTC (History)
3 users (show)

See Also:
mandree: maintainer-feedback-
koobs: merge-quarterly?


Attachments
patch for devel/doxygen (2.92 KB, patch)
2021-10-21 04:26 UTC, Tatsuki Makino
no flags Details | Diff
poudriere log (544.24 KB, text/plain)
2021-10-21 04:29 UTC, Tatsuki Makino
no flags Details
Poudriere build error log (309.22 KB, text/plain)
2025-01-08 13:33 UTC, Tomoaki AOKI
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tatsuki Makino 2021-10-21 04:26:52 UTC
Created attachment 228911 [details]
patch for devel/doxygen

MAKE_JOBS_UNSAFE has been added since 1.8.11 (bug 211447).
This is a patch that makes it unnecessary... maybe :)
Comment 1 Tatsuki Makino 2021-10-21 04:29:30 UTC
Created attachment 228912 [details]
poudriere log

Since most of the time is spent on texlive-texmf extraction, it is less effective :)
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2021-10-21 06:26:21 UTC
Thank you for your patch. Has this been submitted upstream? If so please include the upstream issue, pr reference
Comment 3 Tatsuki Makino 2021-10-21 06:44:12 UTC
(In reply to Kubilay Kocak from comment #2)

I don't know if it has been reported, since I just came up with the idea and created it a few hours ago :)
And, I have not reported it upstream.
Comment 4 Matthias Andree freebsd_committer freebsd_triage 2025-01-05 23:13:48 UTC
Maintainer timeout, 39 months.
Comment 5 commit-hook freebsd_committer freebsd_triage 2025-01-06 00:44:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8492d9bdf19a0c516f98c71e15d22e72bf27f498

commit 8492d9bdf19a0c516f98c71e15d22e72bf27f498
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2025-01-05 23:14:27 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2025-01-06 00:43:34 +0000

    devel/doxygen: Fix parallel examples build (under DOCS)

    Tatsuki Makino wrote the original patch vs. Doxygen 1.9.1, but it no
    longer applied, so I manually re-did following his example.

    While here, ditch the :noninja, 1.9.6 builds fine with Ninja, too.

    Obtained from:  tatsuki_makino@hotmail.com
    PR:             259331
    Approved by:    maintainer timeout (fluffy@, 39 months)

 devel/doxygen/Makefile                             |  4 +---
 .../files/patch-examples_CMakeLists.txt (new)      | 26 ++++++++++++++++++++++
 2 files changed, 27 insertions(+), 3 deletions(-)
Comment 6 Tomoaki AOKI 2025-01-08 13:33:52 UTC
Created attachment 256538 [details]
Poudriere build error log

Unfortunately, fails to build with the error attached.

Switching ninja to samurai didn't help.
Running `make MAKE_JOBS_UNSAFE=yes` on bare-metal engirinment without ccache didn't help, too.

Built using poudriere on:
  stable/14, amd64 at commit 5ada29ab253dcaf09bbae62e4b21e9205bd8b157

Ports tree is:
  main branch at commit e509f97867c69e81f6aad3501ef42c26f2527100

Options:
# This file is auto-generated by 'make config'.
# Options for doxygen-1.9.6_2,2
_OPTIONS_READ=doxygen-1.9.6_2,2
_FILE_COMPLETE_OPTIONS_LIST=DOCS GRAPHVIZ LATEX QT5 SEARCH
OPTIONS_FILE_UNSET+=DOCS
OPTIONS_FILE_SET+=GRAPHVIZ
OPTIONS_FILE_UNSET+=LATEX
OPTIONS_FILE_UNSET+=QT5
OPTIONS_FILE_UNSET+=SEARCH
Comment 7 Matthias Andree freebsd_committer freebsd_triage 2025-01-08 14:39:52 UTC
Aoki-san, thanks for the report.

This looks like an incompatibility of the older version of TinyDeflate that we patched onto Doxygen with the compiler of stable/14, which in your case, is clang-19.1, which made -Wmissing-template-arg-list-after-template-kw a default error. 

https://github.com/bisqwit/TinyDeflate/commit/68ced8bd5c819264e628d4f063500753b77f613d seems to fix it, importing...
Comment 8 Matthias Andree freebsd_committer freebsd_triage 2025-01-08 14:55:29 UTC
Fixed per 4bd9003d8ca9
Comment 9 commit-hook freebsd_committer freebsd_triage 2025-01-08 14:55:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4bd9003d8ca98b85964a07b23454f3c2607e191b

commit 4bd9003d8ca98b85964a07b23454f3c2607e191b
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2025-01-08 14:51:02 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2025-01-08 14:53:06 +0000

    devel/doxygen: Fix TinyDeflate's clang-19 compatibility

    Clang >= 19.0 requires a template argument list after the template
    keyword for CWG96 compliance, see
    https://github.com/llvm/llvm-project/pull/80801

    Obtained from:  Bernhard Rosenkränzer, via
    https://github.com/bisqwit/TinyDeflate/commit/68ced8bd5c819264e628d4f063500753b77f613d

    PR:             259331 (comment #6)
    Reported by:    Tamaoki Aoki
    Approved by:    portmgr@ (blanket approval for fixing broken builds)

 .../files/patch-TinyDeflate_gunzip.hh (new)        | 37 ++++++++++++++++++++++
 1 file changed, 37 insertions(+)
Comment 10 commit-hook freebsd_committer freebsd_triage 2025-01-08 14:56:33 UTC
A commit in branch 2025Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3cf80a2187c4855c9b4af644c39e82db8321b10e

commit 3cf80a2187c4855c9b4af644c39e82db8321b10e
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2025-01-08 14:51:02 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2025-01-08 14:55:47 +0000

    devel/doxygen: Fix TinyDeflate's clang-19 compatibility

    Clang >= 19.0 requires a template argument list after the template
    keyword for CWG96 compliance, see
    https://github.com/llvm/llvm-project/pull/80801

    Obtained from:  Bernhard Rosenkränzer, via
    https://github.com/bisqwit/TinyDeflate/commit/68ced8bd5c819264e628d4f063500753b77f613d

    PR:             259331 (comment #6)
    Reported by:    Tamaoki Aoki
    Approved by:    portmgr@ (blanket approval for fixing broken builds)

    (cherry picked from commit 4bd9003d8ca98b85964a07b23454f3c2607e191b)

 .../files/patch-TinyDeflate_gunzip.hh (new)        | 37 ++++++++++++++++++++++
 1 file changed, 37 insertions(+)
Comment 11 Tomoaki AOKI 2025-01-08 23:20:12 UTC
(In reply to Matthias Andree from comment #8)
Confirmed built fine after the commit.
Thanks for the quick fix!