Bug 259598 - multimedia/mpv: Fix incorrect Lua supported versions, Add Lua OPTION
Summary: multimedia/mpv: Fix incorrect Lua supported versions, Add Lua OPTION
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-multimedia (Nobody)
URL:
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2021-11-01 18:15 UTC by Vladimir Druzenko
Modified: 2021-12-11 17:20 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+
koobs: merge-quarterly?

Attachments
make lua optional dependency and (1.49 KB, patch)
2021-11-01 18:15 UTC, Vladimir Druzenko 		no flags Details | Diff
make lua optional dependency v2 (keep LUA on by default) (1.55 KB, patch)
2021-11-02 18:42 UTC, Vladimir Druzenko 		no flags Details | Diff
make lua optional dependency v3 (keep LUA on by default) (1.56 KB, patch)
2021-11-16 23:33 UTC, Vladimir Druzenko 		no flags Details | Diff
make lua optional dependency v4 (keep LUA on by default) (1.52 KB, patch)
2021-12-08 01:18 UTC, Vladimir Druzenko 		vvd: maintainer-approval?
Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2021-11-01 18:15:39 UTC 
Created attachment 229204 [details]
make lua optional dependency and

Lua isn't mandatory dependency for mpv and mpv doesn't support lua 5.3.

Tested on 12.2 amd64: check-plist/build/install/run.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-11-02 01:02:53 UTC 
Thank you for the patch. Please add LUA to OPTIONS_DEFAULT such that the option and supported Lua version bugfix can be merged to quarterly (fixing the bug), without modifying functional default behaviour. This can then be followed up with a proposal to remove from OPTIONS_DEFAULT if appropriate and accepted
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2021-11-02 18:42:35 UTC 
Created attachment 229231 [details]
make lua optional dependency v2 (keep LUA on by default)
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2021-11-05 14:41:37 UTC 
(In reply to Kubilay Kocak from comment #1)
I did as you asked.
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2021-11-13 19:31:30 UTC 
(In reply to Kubilay Kocak from comment #1)
Something wrong with patch?
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2021-11-16 23:33:23 UTC 
Created attachment 229543 [details]
make lua optional dependency v3 (keep LUA on by default)

Small fix.
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2021-12-08 01:18:51 UTC 
Created attachment 229969 [details]
make lua optional dependency v4 (keep LUA on by default)

Patch updated for current version of the port.
Comment 7 Tobias C. Berner freebsd_committer freebsd_triage 2021-12-10 05:29:17 UTC 
Moin moin 

Why add a None option, instead of making it an OPTION_RADIO?


mfg Tobias
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2021-12-10 12:00:38 UTC 
(In reply to Tobias C. Berner from comment #7)
> Why add a None option, instead of making it an OPTION_RADIO?
Need "if" in Makefile for turn off both.
Or none option with "LUA_NONE_CONFIGURE_ON=--disable-lua" only.
Comment 9 commit-hook freebsd_committer freebsd_triage 2021-12-11 09:32:25 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cd43b2526fd466e46532dad30cbf37e2296a845c

commit cd43b2526fd466e46532dad30cbf37e2296a845c
Author:     VVD <vvd@unislabs.com>
AuthorDate: 2021-12-11 09:25:48 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2021-12-11 09:30:00 +0000

    multimedia/mpv: fix lua option handling

    mpv supports
      - no lua
      - luajit
      - lua51-52

    The new options added support to select between these.
      - LUA_NONE
      - LUAJIT (previous OFF by default)
      - LUA (previously on when LUAJIT=OFF)

    So the default remains to use lang/lua5[12].

    PR:             259598

 multimedia/mpv/Makefile | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)
Comment 10 Vladimir Druzenko freebsd_committer freebsd_triage 2021-12-11 17:20:43 UTC 
Thanks!