Bug 259650 - devel/libunwind: enable on armv6
Summary: devel/libunwind: enable on armv6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords: easy, feature
Depends on:
Blocks:
 
Reported: 2021-11-04 19:56 UTC by Robert Clausecker
Modified: 2021-12-21 20:46 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)
fuz: merge-quarterly?


Attachments
devel/libunwind: enable on armv6 (1.06 KB, patch)
2021-11-04 19:56 UTC, Robert Clausecker
fuz: maintainer-approval? (sunpoet)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2021-11-04 19:56:54 UTC
Created attachment 229272 [details]
devel/libunwind: enable on armv6

With the attached patch, devel/libunwind succesfully builds on armv6 FreeBSD 13.

Please apply the patch so the port can be used there.

Please MFH if possible.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-11-05 09:32:26 UTC
This is however unsupported by upstream
https://github.com/libunwind/libunwind#libunwind ?
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2021-11-05 09:35:43 UTC
(In reply to Daniel Engberg from comment #1)

It has been successfully used for months with armv7.  So even if it's not officially supported, it does seem to work.
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2021-11-05 20:59:49 UTC
(In reply to Robert Clausecker from comment #2)

> It has been successfully used for months with armv7.

To be clear, did you use it on armv6?
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2021-11-05 21:29:03 UTC
(In reply to Po-Chuan Hsieh from comment #3)

No, only on armv7.  But there is actually a port to FreeBSD/armv6 in the upstream code base, see this commit:

https://github.com/libunwind/libunwind/commit/fd02fd59e7462f49311d4e0d6547aacf48fe072b
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2021-11-28 23:12:33 UTC
(In reply to Po-Chuan Hsieh from comment #3)

Can we move ahead with this patch?  It would be great to have it in so I can continue with testing the ports that depend on devel/libunwind on armv6.
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-12-21 19:52:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=811eadd958852e0974380e7b416b193d64236fea

commit 811eadd958852e0974380e7b416b193d64236fea
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-12-21 18:55:05 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2021-12-21 18:55:05 +0000

    devel/libunwind: Allow build on armv6

    PR:             259650

 devel/libunwind/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2021-12-21 20:46:24 UTC
Committed. Thanks!