Bug 259685 - net-im/purple-hangouts: Update to 20210630
Summary: net-im/purple-hangouts: Update to 20210630
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL: https://github.com/EionRobb/purple-ha...
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2021-11-06 20:26 UTC by Jose G. Juanino
Modified: 2021-12-23 21:23 UTC (History)
3 users (show)

See Also:
jjuanino: maintainer-feedback+

Attachments
update to 20210630 (4.09 KB, patch)
2021-11-06 20:26 UTC, Jose G. Juanino 		no flags Details | Diff
update to 20210630 (3.60 KB, patch)
2021-11-20 12:49 UTC, Jose G. Juanino 		jjuanino: maintainer-approval+
Details | Diff
poudriere log (49.18 KB, text/plain)
2021-11-20 12:56 UTC, Jose G. Juanino 		jjuanino: maintainer-approval+
Details
remove NLS stuff (3.31 KB, patch)
2021-11-21 10:05 UTC, Jose G. Juanino 		jjuanino: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jose G. Juanino 2021-11-06 20:26:43 UTC 
Created attachment 229334 [details]
update to 20210630

Upstream has moved from bitbucket to GitHub: update the port accordingly, and get the last version, but no functional changes have been incorporated.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2021-11-19 08:31:53 UTC 
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]

^Triage: Please confirm this change passes QA (portlint, poudriere at least).
--
https://www.freebsd.org/doc/en/books/porters-handbook/testing.html


# USES block
USES
+USE_GITHUB
+GH_ACCOUNT
+GH_TAGNAME
USE_GNOME
+USE_LDCONFIG

# Standard bsd.port.mk variables
PATCH_STRIP

-USE_GITHUB
-GH_ACCOUNT
-GH_TAGNAME
# Packaging list block
+PLIST_FILES

# Options definitions
OPTIONS_DEFINE

# Options helpers
NLS_USES

-USE_LDCONFIG


Thanks!
Comment 2 Jose G. Juanino 2021-11-20 12:49:25 UTC 
Created attachment 229606 [details]
update to 20210630
Comment 3 Jose G. Juanino 2021-11-20 12:56:35 UTC 
Created attachment 229607 [details]
poudriere log
Comment 4 Jose G. Juanino 2021-11-20 12:59:31 UTC 
(In reply to Fernando Apesteguía from comment #1)
Hi Fernando, I have fixed the patch following your suggestions. Find attached the poudriere log. Patch also passes portlint -A.

Regards
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2021-11-20 17:04:27 UTC 
Great work, thanks!
Comment 6 Jose G. Juanino 2021-11-21 10:05:29 UTC 
Created attachment 229631 [details]
remove NLS stuff

As discussed in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259687, I have realized that NLS stuff is useless, so I submit a new patch version with the fix.
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-12-23 21:21:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a49daaafcd5f1bdad87f83f95a1f49eaced3c4c7

commit a49daaafcd5f1bdad87f83f95a1f49eaced3c4c7
Author:     Jose G. Juanino <jjuanino@gmail.com>
AuthorDate: 2021-12-23 20:59:28 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2021-12-23 21:20:59 +0000

    net-im/purple-hangouts: Update to 20210630

    Unfortunately upstream doesn't provide a changelog so you need to refer to
    commit log instead

    PR:             259685
    Approved by:    mentors (implicit)

 net-im/purple-hangouts/Makefile               | 20 +++++---------------
 net-im/purple-hangouts/distinfo               |  6 +++---
 net-im/purple-hangouts/files/patch-429 (gone) | 26 --------------------------
 net-im/purple-hangouts/pkg-descr              |  2 +-
 4 files changed, 9 insertions(+), 45 deletions(-)
Comment 8 Daniel Engberg freebsd_committer freebsd_triage 2021-12-23 21:23:49 UTC 
Committed, thanks!