Bug 259701 - devel/wasm3: Fix compilation and clean up port
Summary: devel/wasm3: Fix compilation and clean up port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-07 18:20 UTC by Daniel Engberg
Modified: 2021-11-14 07:49 UTC (History)
2 users (show)

See Also:
freebsd: maintainer-feedback+


Attachments
Patch for wasm3 (2.37 KB, patch)
2021-11-07 18:20 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2021-11-07 18:20:22 UTC
Created attachment 229347 [details]
Patch for wasm3

Rephrase COMMENT and pkg-descr to sound less like a sales pitch
Disable -march=native as this overrides settings by the framework and fails on multiple non x86 platforms
Remove GitHub related variables that are already defined
Replace += with = for GH_TUPLE
Remove forced O3 optimization

References: 
https://portsfallout.com/port/31163/
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github-description
Example 21 "Use of USE_GITHUB with Multiple Distribution Files Using GH_TUPLE" in Porters Handbook
https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags

Compile tested on FreeBSD 13.0-STABLE #1 stable/13-n247667-dc9094140c9 (amd64) (make, make check-plist)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 13.0-RELEASE (i386)
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-11-14 07:37:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b62fdebf66a9200ea7849b664abe6619216bd33c

commit b62fdebf66a9200ea7849b664abe6619216bd33c
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2021-11-14 07:30:46 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2021-11-14 07:34:25 +0000

    devel/wasm3: Fix compilation and clean up port.

    Rephrase COMMENT and pkg-descr to sound less like a sales pitch
    Disable -march=native as this overrides settings by the framework and fails on multiple non x86 platforms
    Remove GitHub related variables that are already defined
    Replace += with = for GH_TUPLE
    Remove forced O3 optimization

    PR:             259701
    Approved by:    portmgr (build fix blanket)
    Differential Revision:  https://reviews.freebsd.org/D32883

 devel/wasm3/Makefile                   | 11 ++++++-----
 devel/wasm3/files/patch-CMakeLists.txt | 17 +++++++++++++++--
 devel/wasm3/pkg-descr                  |  3 ++-
 3 files changed, 23 insertions(+), 8 deletions(-)