Bug 259712 - games/abstreet: Update to 0.2.64
Summary: games/abstreet: Update to 0.2.64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-08 12:39 UTC by Mikael Urankar
Modified: 2021-11-09 19:47 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
v0 (172.07 KB, patch)
2021-11-08 12:39 UTC, Mikael Urankar
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2021-11-08 12:39:06 UTC
Created attachment 229360 [details]
v0

Please, update abstreet to a newer version. I don't understand why we need to supply some data, here is a patch without the data.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2021-11-08 17:35:09 UTC
Hi Mikael,

Thanks for the patch.

What I don't like about the behavior of the program w/out data is that it opens the dialog box "Couldn't load montlake (in seattle (us)) No such file or directory".
Pressing Ok causes the program to exit.

From the user standpoint the program is broken. It prints error about a missing file and exits.

I'll take it from here and see what to do.

Thank you again,
Yuri
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2021-11-09 19:46:34 UTC
I kept the data in the package because as it is now abstreet isn't able to download data into the user's home directory. Most likely they assume that users are building manually and the executable downloads into the same folder where the executable resides. I submitted bug reports to the upstream for this.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-11-09 19:47:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2749ccb4d969d8091039cbeeb46cd328a27b9572

commit 2749ccb4d969d8091039cbeeb46cd328a27b9572
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2021-11-09 19:42:55 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2021-11-09 19:47:05 +0000

    games/abstreet: Update 0.2.9-49 -> 0.2.64

    PR:             259712
    Original patch submitted by:    mikael

 games/abstreet/Makefile                            |  702 ++++----
 games/abstreet/distinfo                            | 1712 ++++++++++----------
 .../patch-cargo-crates_rfd-0.4.0_Cargo.toml (new)  |   24 +
 ...tch-cargo-crates_rfd-0.4.0_src_backend.rs (new) |   11 +
 .../files/patch-cargo-crates_ring-0.16.20 (new)    |  125 ++
 .../files/patch-widgetry_Cargo.toml (gone)         |   11 -
 games/abstreet/pkg-plist                           |  223 ++-
 7 files changed, 1488 insertions(+), 1320 deletions(-)