FAILED: libfreerdp/CMakeFiles/freerdp.dir/crypto/tls.c.o /usr/local/bin/ccache /usr/local/libexec/ccache/cc -DCMAKE_BUILD_TYPE=Release -DEXT_PATH=\"/usr/local/lib/freerdp2/extensions\" -DFREERDP_EXPORTS -DHAVE_CONFIG_H -DSWSCALE_FOUND=1 -DWINPR_EXPORTS -DWITH_OPENSSL -DWITH_X11 -DWITH_XKBFILE -D_FILE_OFFSET_BITS=64 -Dfreerdp_EXPORTS -I/tmp/ports/usr/ports/net/freerdp/work/.build -I/tmp/ports/usr/ports/net/freerdp/work/.build/include -I/tmp/ports/usr/ports/net/freerdp/work/freerdp-2.4.1/include -I/tmp/ports/usr/ports/net/freerdp/work/freerdp-2.4.1/winpr/include -I/tmp/ports/usr/ports/net/freerdp/work/.build/winpr/include -O2 -pipe -O3 -pipe -funroll-loops -DSTRIP_FBSDID -D_FORTIFY_SOURCE=2 -mretpoline -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -fdebug-prefix-map=/tmp/ports/usr/ports/net/freerdp/work/freerdp-2.4.1=. -Wno-unused-parameter -Wno-unused-macros -Wno-padded -Wno-c11-extensions -Wno-gnu -Wno-unused-command-line-argument -Wno-deprecated-declarations -fno-omit-frame-pointer -DWINPR_DLL -O2 -pipe -O3 -pipe -funroll-loops -DSTRIP_FBSDID -D_FORTIFY_SOURCE=2 -mretpoline -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -fdebug-prefix-map=/tmp/ports/usr/ports/net/freerdp/work/freerdp-2.4.1=. -fPIC -MD -MT libfreerdp/CMakeFiles/freerdp.dir/crypto/tls.c.o -MF libfreerdp/CMakeFiles/freerdp.dir/crypto/tls.c.o.d -o libfreerdp/CMakeFiles/freerdp.dir/crypto/tls.c.o -c /tmp/ports/usr/ports/net/freerdp/work/freerdp-2.4.1/libfreerdp/crypto/tls.c ../freerdp-2.4.1/libfreerdp/crypto/tls.c:355:13: error: incomplete definition of type 'struct ssl_st' tls->ssl->wbio = tls->ssl->rbio = NULL; ~~~~~~~~^ /usr/local/include/openssl/ossl_typ.h:160:16: note: forward declaration of 'struct ssl_st' typedef struct ssl_st SSL; ^ ../freerdp-2.4.1/libfreerdp/crypto/tls.c:355:30: error: incomplete definition of type 'struct ssl_st' tls->ssl->wbio = tls->ssl->rbio = NULL; ~~~~~~~~^ /usr/local/include/openssl/ossl_typ.h:160:16: note: forward declaration of 'struct ssl_st' typedef struct ssl_st SSL; ^ 2 errors generated.
Created attachment 229382 [details] pa
Have you suggested this patch to upstream?
Created attachment 229393 [details] patch They already have another one patch in base: https://github.com/FreeRDP/FreeRDP/pull/7033
Commit from May is not in release 2.4.1 from October - weird.
(In reply to Ivan Rozhuk from comment #3) Upstream ask for pull request to stable-2.0.
This commit is for branch stable-2.0: https://github.com/FreeRDP/FreeRDP/commit/bfbef39759b9641a4fab8b75b9243c48cb0789ac Replace please commit in Makefile and I'll approve patch. Thanks.
Created attachment 230323 [details] Patch to the ports tree with update patch commit Updated patch with the suggested commit. Also some minor improvements regarding ordering of the variables in the Makefile.
Comment on attachment 230323 [details] Patch to the ports tree with update patch commit Look good for me. Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=fc6db685f4ad53d532982cbce840f29290970193 commit fc6db685f4ad53d532982cbce840f29290970193 Author: Fernando Apesteguía <fernape@FreeBSD.org> AuthorDate: 2021-12-22 16:35:38 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2021-12-23 09:51:08 +0000 net/freerdp: Fix build with libressl 3.4.1 Apply patch from: https://github.com/FreeRDP/FreeRDP/commit/bfbef39759b9641a4fab8b75b9243c48cb0789ac While here, pet linters. PR: 259740 Reported by: rozhuk.im@gmail.com Approved by: vvd@unislabs.com (maintainer) net/freerdp/Makefile | 12 ++++++++---- net/freerdp/distinfo | 4 +++- 2 files changed, 11 insertions(+), 5 deletions(-)
Committed, Thanks!
Created attachment 230421 [details] Fix patch check sum Don't know why, but patch from github changed in size.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b7a6b250ed8795e43c7c0efc4c3708093aff8c34 commit b7a6b250ed8795e43c7c0efc4c3708093aff8c34 Author: Fernando Apesteguía <fernape@FreeBSD.org> AuthorDate: 2021-12-26 15:19:37 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2021-12-26 18:40:52 +0000 net/freerdp: recalculate checksum for patch. For some reason, the patch in GH changed its size: => Attempting to fetch https://github.com/FreeRDP/FreeRDP/commit/bfbef39759b9641a4fab8b75b9243c48cb0789ac.patch fetch: https://github.com/FreeRDP/FreeRDP/commit/bfbef39759b9641a4fab8b75b9243c48cb0789ac.patch: size mismatch: expected 2184, actual 2186 PR: 259740 Reported by: vvd@unislabs.com (maintainer) net/freerdp/distinfo | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Done. Thanks!