Bug 259813 - ports-mgmt/portlint: Don't warn about /etc/fstab and /proc as absolute pathnames
Summary: ports-mgmt/portlint: Don't warn about /etc/fstab and /proc as absolute pathnames
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Joe Marcus Clarke
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2021-11-13 09:55 UTC by Gerald Pfeifer
Modified: 2021-11-13 18:29 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)

Attachments
Tested patch (375 bytes, patch)
2021-11-13 09:55 UTC, Gerald Pfeifer 		gerald: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer freebsd_committer freebsd_triage 2021-11-13 09:55:48 UTC 
Created attachment 229465 [details]
Tested patch

portlint currently warns about /etc/fstab and /proc being absolute
pathnames. Which is correct, but unavoidable.

This triggers in the emulators/wine port, for example (alas, not,
only when a build directory is available).
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-11-13 18:23:20 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c8fa510269fd8739e87703632b626dc0bccfe2ce

commit c8fa510269fd8739e87703632b626dc0bccfe2ce
Author:     Joe Marcus Clarke <marcus@FreeBSD.org>
AuthorDate: 2021-11-13 18:19:34 +0000
Commit:     Joe Marcus Clarke <marcus@FreeBSD.org>
CommitDate: 2021-11-13 18:19:34 +0000

    ports-mgmt/portlint: Update to 2.19.9

    * Update CONFLICTS check to cover all variables and checks performed by
      bsd.port.mk [1]
    * Add some other allowed fully-qualified paths [2]
    * Don't consider variable substitution when checking DEPENDS [3]

    PR:             259813 [2]
                    259244 [3]
    Sybmitted by:   se [1]
                    gerald [2]
    Differential Revision:  https://reviews.freebsd.org/D32733 [1]

 ports-mgmt/portlint/Makefile        |  2 +-
 ports-mgmt/portlint/src/portlint.pl | 51 ++++++++++++++++++++++++++-----------
 2 files changed, 37 insertions(+), 16 deletions(-)
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2021-11-13 18:29:05 UTC 
Committed, thanks!