I already e-mailed around 1 month ago but there was no response. The current build of libmediainfo is missing some symbol definitions, see https://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1822968.html This has already been patched upstream, see https://github.com/MediaArea/MediaInfoLib/pull/1434/commits/038dff8433053aada3e8bf34655e2cec67305c5c . # nm -gD /usr/local/lib/libmediainfo.so.0 | grep tfsxml U tfsxml_attr U tfsxml_cmp_charp U tfsxml_enter U tfsxml_init U tfsxml_leave U tfsxml_next U tfsxml_str_charp U tfsxml_value
Created attachment 229533 [details] Patch for libmediainfo Convert to CMake Drop libmms support (deprecated) Disable build of static library Always depend on libtinyxml2 port Rearrange Makefile to follow Porters Handbook more closely Compile and runtime tested on FreeBSD 13.0-STABLE #1 stable/13-n247667-dc9094140c9 (amd64) (make, make check-plist) Poudriere testport OK 12.2-RELEASE (amd64) Poudriere testport OK 13.0-RELEASE (i386)
Hi Johannes, The patch in 259873 and this PR should fix your issue, if possible please test. Best regards, Daniel
Tested the patches, works well and solves the issue (which occurs when using pymediainfo, which seems to use these symbols), thank you!
Great! Thanks for verifying!
Friendly ping sunpoet@
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=aa49adc65a51fff6afe04b2e1b51dc86189af1d2 commit aa49adc65a51fff6afe04b2e1b51dc86189af1d2 Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> AuthorDate: 2021-12-21 18:55:04 +0000 Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> CommitDate: 2021-12-21 18:55:04 +0000 multimedia/libmediainfo: Fix undefined tfsxml_* symbols - Bump PORTREVISION for package change PR: 259853 Reported by: Johannes Falke <johannesfalke@googlemail.com> Obtained from: https://github.com/MediaArea/MediaInfoLib/commit/e40d91326ab070f88d3e8d194268ce3cd9275028 multimedia/libmediainfo/Makefile | 1 + .../libmediainfo/files/patch-Makefile.am (new) | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+)
Committed. Thanks!
Hi sunpoet@ , this patch isn't working as expected for me. I believe this is because it only modifies upstream's Makefile.am. The ports build for this package only calls GNU configure and make, and doesn't run upstream's autogen.sh (which in turn invokes automake), so the generated Makefile is never updated - meaning the fix is bypassed. Bug 259190 proposes the other approach to resolving this, which applies upstream's patch, re-runs autogen.sh, and make makepatch to generate the necessary patch to Makefile.in. Placing the attachment from bug 259190 into files/patch-Makefile.in correctly resolves the reported issue for me. (Incidentally, diizzy@ 's patch attached to this bug converts the build to CMake, which probably works around this issue, but wasn't committed (and I haven't tested it).) Would you please revisit your fix for this package? Thanks!
Re-open PR
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=11d96fa01c90d0ebf49eb5a60e6a3e8c336d75ca commit 11d96fa01c90d0ebf49eb5a60e6a3e8c336d75ca Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> AuthorDate: 2022-03-25 12:46:10 +0000 Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> CommitDate: 2022-03-25 13:36:42 +0000 multimedia/libmediainfo: Fix aa49adc65a51fff6afe04b2e1b51dc86189af1d2 - Bump PORTREVISION for package change Tested with TINYXML2 option disabled. PR: 259190, 259853 multimedia/libmediainfo/Makefile | 4 +-- .../libmediainfo/files/patch-Makefile.am (gone) | 22 ------------ .../libmediainfo/files/patch-Makefile.in (new) | 42 ++++++++++++++++++++++ 3 files changed, 44 insertions(+), 24 deletions(-)