Bug 259883 - sysutils/devcpu-data: make it possible to select no cpu architecture at all
Summary: sysutils/devcpu-data: make it possible to select no cpu architecture at all
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Sean Bruno
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-16 18:49 UTC by Martin Birgmeier
Modified: 2021-11-18 03:59 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sbruno)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Birgmeier 2021-11-16 18:49:09 UTC
Scenario:
- latest ports
- one port build machine (bhyve)
- multiple machines using Intel and AMD CPUs
- microcode should be updated for these machines
- only the microcode for the relevant architecture should be *installed*
- microcodes for both AMD and Intel should be *compiled*

Result:
- If selecting both AMD and Intel in sysutils/devcpu-data, both sub-ports get installed although only one is needed
- If selecting only one sub-port, obviously the data for the other CPU vendor is not built
- Selecting no sub-port leads to an error

Expected result:
- sysutils/devcpu-data should allow me to build from zero to all sub-ports but still build the necessary files to actually use any CPU firmwares if they are available for the machine they are installed on
- Most likely, this could be accomplished by changing the OPTIONS_MULTI=VENDOR to a simple OPTIONS_DEFINE, allowing to deselect all sub-ports and then manually installing them on the target machines as needed.
- As an alternative, each sub-port would simply be equipped with its own rc.d scripts.

-- Martin
Comment 1 Joseph Mingrone freebsd_committer freebsd_triage 2021-11-17 16:49:25 UTC
https://reviews.freebsd.org/D33036
Comment 2 Martin Birgmeier 2021-11-17 18:18:59 UTC
I don't have an account on review.freebsd.org, but looking at the proposed patch I would say it fulfills its purpose!

-- Martin
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-11-18 03:33:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4fbb969613782d1b6cb2c65191c9ed2d339bce20

commit 4fbb969613782d1b6cb2c65191c9ed2d339bce20
Author:     Joseph Mingrone <jrm@FreeBSD.org>
AuthorDate: 2021-11-17 16:21:47 +0000
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2021-11-18 03:31:43 +0000

    sysutils/devcpu-data: Permit neither vendor option to be chosen

    This allows users with both AMD- and Intel-based systems to build and
    install devcpu-data-amd and devcpu-data-intel, but not force either to
    be installed with `pkg install devcpu-data`.

    PR:             259883
    Reported by:    Martin Birgmeier <d8zNeCFG@aon.at>
    Approved by:    sbruno (maintainer)

    Differential Revision:  https://reviews.freebsd.org/D33036

 sysutils/devcpu-data/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 4 Joseph Mingrone freebsd_committer freebsd_triage 2021-11-18 03:59:55 UTC
Thanks for reporting.