Created attachment 229637 [details] Unified diff updating to 1.6.1 Any work done yet on updating to Lumina 1.6.1? Looks like it will not be difficult. Attaching a patch for lumina-core.
(In reply to Jason W. Bacon from comment #0) Thanks Jason, I'll try to update lumina this week-end. However, lumina-core is not the only one port to update see https://www.freshports.org/search.php?stype=name&method=match&query=lumina-&num=10&orderby=category&orderbyupdown=asc&search=Search&format=html&branch=head&page=1
Yes, I'm aware that there are several modules. But -core is likely the biggest and needs to be done before the rest, so I looked into it first. Thanks for maintaining Lumina!
Created attachment 229983 [details] x11/lumina: update to 1.6.1 Jason, Thanks for the patch, I made a tiny fix in post-configure. I'll look to remove the post-configure later. BTW I updated all other ports. If you want to try them. Loïc
My GH branch: https://github.com/lbartoletti/freebsd-ports/tree/lumina-1.6.1
Awesome, nice work... Issues I've noticed so far: 1. CONFLICTS should probably be updated or removed 2. Changing Window Theme under Window Mnaager doesn't work 3. The default panels no longer include Start Menu, but now have Application Menu in its place. Not technically a bug, but seems like a poor choice from my perspective since it makes Lumina look less capable. Might be an upstream choice, but if I were maintainer I'd patch it in the port for now.
Upstream PR for window theme: https://github.com/lumina-desktop/lumina/issues/787
(In reply to Jason W. Bacon from comment #6) That's not a PR that's an issue. Did you mean to file a PR?
(In reply to q5sys from comment #7) No, I meant to reference the Github issue.
(In reply to Jason W. Bacon from comment #8) Ok, just wanted to make sure. I got excited for a moment that someone had PR for me that would fix something. :P
(In reply to Jason W. Bacon from comment #6) Jason, except this issue, shall I commit the update?
@Loic FYI, 1.6.2 will be coming out this Saturday/Sunday. After that release there should be several months before the next one.
I'm going to try to see if I can track down that WM theme change bug that Jason reported, and if I can determine the problem (might just be a simple issue) I'll try to that in. However If I cant figure that out quickly or I cant fix it with a quick patch that'll get pushed back to 1.6.3
(In reply to Loïc Bartoletti from comment #10) I'd say the inability to switch window themes is a show-stopper. There's also an issue I didn't mention here: Resizing the preferences window is incredibly slow. The redraws lag way behind mouse movement. When these two things are fixed, I'd say we're good to go. I didn't notice any other serious regressions.
(In reply to q5sys from comment #12) Cool, thanks for the heads-up.
@ Jason can you throw me a ticket on github about the preferences issue bug you've mentioned. This is the first I'm hearing of it, since I do all my ticket tracking on github.
(In reply to q5sys from comment #15) I had meant to do that, sorry. It's there now.
(In reply to Jason W. Bacon from comment #5) > 2. Changing Window Theme under Window Mnaager doesn't work This has been fixed. > 3. The default panels no longer include Start Menu, but now have Application Menu in its place. Not technically a bug, but seems like a poor choice from my perspective since it makes Lumina look less capable. Might be an upstream choice, but if I were maintainer I'd patch it in the port for now. The application menu is the default, however the previous menu is still included. It's one of the panel options that can be configured. There are three types of "start menus" available in Lumina. It can be changed using lumina-config under Interface Configuration > Panels. "Application Menu" is the classic style of start menu that most desktops include. "Start Menu" is what was the previous default. "User Menu" is original start menu made for Lumina. All three of these options are still available. In speaking with people over the years, the feedback I have gotten is that most end up switching to the Application Menu immediately upon installing the desktop. That is why this has been set as the default, but I have not removed any of the previous menus, they are all still available. I have considered doing a 'first-start' option where someone chooses which they prefer, but I personally dont like being required to make decisions on a new desktop when I first start it... so I haven't done that. However more on this later. This menu change should only affect new installs of Lumina, as your personal lumina configuration should not be overwritten when upgrading. If you have a previous configuration you prefer, copy the ~/.config/lumina-desktop/ folder to new installs to use your preferred configuration. To make it easier for people who use lumina and have their own unique preferences for how it should be set up. I do have a task on my to-do list (finally made a ticket for it on github) to create an export/import utility for Lumina so it is easy for users to save/restore their custom configurations easily.
(In reply to q5sys from comment #17) Yes, I was aware that it can be changed in the settings. I agree that users shouldn't be burdened with another question at install time. I don't mind manually switching it on new installations if most users prefer a simple app menu. Just wanted to make sure this was a deliberate change and put in my vote. Thanks...
(In reply to q5sys from comment #17) Window theme patches were imported to my WIP port and they appear to work. https://github.com/outpaddling/freebsd-ports-wip/tree/master/lumina-coreutils This also resolved the slow resizing of the settings window. I think at this point we might as well wait for 1.6.2, though.
https://github.com/lumina-desktop/lumina/releases/tag/v1.6.2
(In reply to q5sys from comment #20) Slick. I updated my WIP ports to 1.6.2: https://github.com/outpaddling/freebsd-ports-wip FYI, the screen resize issue got worse. After resizing a vbox screen running 1.6.2, the panels disappear for good. I'll ping the Github issue as well.
(In reply to Jason W. Bacon from comment #21) If I'm not wrong, I know that Lumina is not suitable for VM (Virtualbox only?). Have you tried on a dedicated computer?
Yeah, I have 1.6.2 running on an old Toshiba Satellite. There don't seem to be any show-stoppers. One remaining issue that's easily worked around be selecting a different WM theme: https://github.com/lumina-desktop/lumina/issues/789 Correct on the vbox issue: https://github.com/lumina-desktop/lumina/issues/536 Hopefully this one will be fixed in 1.6.3, but it's not a regression so I say go ahead with the 1.6.2 commit.
(In reply to Jason W. Bacon from comment #23) I have been unable to reproduce the issue you're having on actual hardware. I've spoken with a few people about it and we're trying to find a time when we can sync up to dig into what might be the issue. But currently our schedules have not worked out. For now, as much as I hate to say it, I'd suggest you use something other than Lumina in virtualbox.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=623f3ae564be88376786d5d67e18a017711126a4 commit 623f3ae564be88376786d5d67e18a017711126a4 Author: Loïc Bartoletti <lbartoletti@FreeBSD.org> AuthorDate: 2022-01-29 16:13:50 +0000 Commit: Loïc Bartoletti <lbartoletti@FreeBSD.org> CommitDate: 2022-01-29 16:14:50 +0000 lumina: Update to 1.6.2 Changes: - 1.6.1: https://lumina-desktop.org/post/2021-10-05/ - 1.6.2: https://lumina-desktop.org/post/2021-12-25/ PR: 259965 Reported by: jwb Tested by: jwb deskutils/lumina-archiver/Makefile | 3 +- deskutils/lumina-archiver/distinfo | 6 +- deskutils/lumina-calculator/Makefile | 5 +- deskutils/lumina-calculator/distinfo | 6 +- deskutils/lumina-fileinfo/Makefile | 3 +- deskutils/lumina-fileinfo/distinfo | 6 +- deskutils/lumina-fm/Makefile | 3 +- deskutils/lumina-fm/distinfo | 6 +- deskutils/lumina-fm/pkg-plist | 1 - deskutils/lumina-mediaplayer/Makefile | 3 +- deskutils/lumina-mediaplayer/distinfo | 6 +- deskutils/lumina-pdf/Makefile | 5 +- deskutils/lumina-pdf/distinfo | 6 +- .../lumina-pdf/files/patch-Annotation.h (gone) | 10 - .../lumina-pdf/files/patch-PrintWidget.cpp (gone) | 11 - .../lumina-pdf/files/patch-drawablepage.h (gone) | 10 - deskutils/lumina-photo/Makefile | 3 +- deskutils/lumina-photo/distinfo | 6 +- deskutils/lumina-screenshot/Makefile | 3 +- deskutils/lumina-screenshot/distinfo | 6 +- deskutils/lumina-textedit/Makefile | 3 +- deskutils/lumina-textedit/distinfo | 6 +- x11/lumina-core/Makefile | 9 +- x11/lumina-core/distinfo | 6 +- x11/lumina-core/pkg-plist | 472 ++++++++++++--------- x11/lumina-coreutils/Makefile | 2 +- x11/lumina-coreutils/distinfo | 6 +- x11/lumina/Makefile | 2 +- 28 files changed, 313 insertions(+), 301 deletions(-)
Committed, thanks!
Seems xscreensaver is no longer needed and should probably be removed as a lumina-core dependency.
(In reply to Jason W. Bacon from comment #27) FYI: https://github.com/lumina-desktop/lumina/issues/808
The new Lumina screensaver is not finished and should not have been enabled in this release. Working on disabling it so we can continue to use xscreensaver for now.