Bug 260124 - [NEW PORT] emulators/ripes: Graphical RISC-V simulator
Summary: [NEW PORT] emulators/ripes: Graphical RISC-V simulator
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-29 20:03 UTC by Mitchell Clay
Modified: 2022-01-10 18:04 UTC (History)
1 user (show)

See Also:

Attachments
port diff (10.49 KB, patch)
2021-11-29 20:03 UTC, Mitchell Clay 		no flags Details | Diff
0001-Add-emulators-ripes-Graphical-RISC-V-simulator.patch (6.87 KB, patch)
2021-12-21 10:13 UTC, Li-Wen Hsu 		no flags Details | Diff
Fixed Makefile (7.51 KB, patch)
2022-01-05 20:29 UTC, Mitchell Clay 		no flags Details | Diff
poudriere log (342.42 KB, text/plain)
2022-01-05 20:33 UTC, Mitchell Clay 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mitchell Clay 2021-11-29 20:03:33 UTC 
Created attachment 229801 [details]
port diff
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2021-12-21 10:13:37 UTC 
Created attachment 230285 [details]
0001-Add-emulators-ripes-Graphical-RISC-V-simulator.patch
Comment 2 Li-Wen Hsu freebsd_committer freebsd_triage 2021-12-21 10:40:54 UTC 
I've modified the patch a little bit, to make it built in a clean environment, i.e., poudriere. However, the whole package build still fails in the installing step, it should install files in STAGE directory but not directly in PREFIX:

https://gist.github.com/lwhsu/ea52e6106ccac58ef599b293f5ecd8d4#file-13_0_amd64-default-log-L918-L921

I'm not familiar with cmake, do you think you can help fix this? Thanks!
Comment 3 Mitchell Clay 2022-01-05 20:29:46 UTC 
Created attachment 230743 [details]
Fixed Makefile

fixed build issue with:
CMAKE_INSTALL_PREFIX=   ${STAGEDIR}${PREFIX}
Comment 4 Mitchell Clay 2022-01-05 20:33:40 UTC 
Created attachment 230744 [details]
poudriere log

The latest patch should fix it.
Attaching my poudriere log just in case.
Comment 5 Li-Wen Hsu freebsd_committer freebsd_triage 2022-01-07 07:11:47 UTC 
(In reply to Mitchell Clay from comment #3)
Thanks, the new patch looks and tests good.
One final question, any reason that we need USE_QT=buildtools (remove _build suffix)? Is that also a run dependency?
Comment 6 Mitchell Clay 2022-01-07 15:42:15 UTC 
Sorry, I forgot to put the suffix when I was re-testing with poudriere. It is not a run-time dependency.
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-01-10 18:02:28 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=885796f15ae920cfa2a400e42fd1e2bdb209d7b2

commit 885796f15ae920cfa2a400e42fd1e2bdb209d7b2
Author:     Mitchell Clay <mclay@astate.edu>
AuthorDate: 2022-01-10 17:59:51 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2022-01-10 17:59:51 +0000

    Add emulators/ripes: Graphical RISC-V simulator

    PR:             260124

 emulators/Makefile                               |  1 +
 emulators/ripes/Makefile (new)                   | 26 ++++++++
 emulators/ripes/distinfo (new)                   | 13 ++++
 emulators/ripes/files/patch-CMakeLists.txt (new) | 83 ++++++++++++++++++++++++
 emulators/ripes/pkg-descr (new)                  | 11 ++++
 emulators/ripes/pkg-plist (new)                  | 11 ++++
 6 files changed, 145 insertions(+)
Comment 8 Li-Wen Hsu freebsd_committer freebsd_triage 2022-01-10 18:03:03 UTC 
New port added.  Please consider upstream the local patches if possible.  Thanks!
Comment 9 Mitchell Clay 2022-01-10 18:04:19 UTC 
Great, thanks for helping me with my first port!