Bug 260633 - games/seabattle: update to 1.1-b and unbreak on FreeBSD 13
Summary: games/seabattle: update to 1.1-b and unbreak on FreeBSD 13
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hiroki Tagato
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-23 08:53 UTC by Robert Clausecker
Modified: 2021-12-25 02:39 UTC (History)
1 user (show)

See Also:

Attachments
games/seabattle: update to 1.1-b (9.23 KB, patch)
2021-12-23 08:53 UTC, Robert Clausecker 		fuz: maintainer-approval+
Details | Diff
games/seabattle: update to 1.1 (9.21 KB, patch)
2021-12-24 09:48 UTC, Robert Clausecker 		fuz: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2021-12-23 08:53:11 UTC 
Created attachment 230335 [details]
games/seabattle: update to 1.1-b

After having sent a number of FreeBSD patches to the author, he
updated the project and incorporated them.  A proper version 1.1
might follow which is why DISTVERSION is 1.1-b instead of 1.1b
as given by upstream.

 - remove patches incorporated by upstream
 - unbreak build on FreeBSD 13
 - set LICENSE to MIT
 - take up maintainership of this unmaintained port

Tested with Poudriere on armv7 arm64 FreeBSD 13.
Portlint is happy with the port.
Comment 1 Hiroki Tagato freebsd_committer freebsd_triage 2021-12-24 08:33:46 UTC 
It appears the upstream has just released version 1.1. Could you check and update the patch if needed?
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2021-12-24 09:48:30 UTC 
Created attachment 230369 [details]
games/seabattle: update to 1.1

Update patch to version 1.1

---

After having sent a number of FreeBSD patches to the author, he
updated the project and incorporated them.  So this is mainly a
patch release

 - remove patches incorporated by upstream
 - unbreak build on FreeBSD 13
 - set LICENSE to MIT
 - depend on audio/alsa-utils if audio output is desired
 - take up maintainership of this unmaintained port

Tested with Poudriere on armv7 arm64 FreeBSD 13.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-12-25 02:38:33 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a7bca39bced2daee9b144193caa8e7ff7baeeb6f

commit a7bca39bced2daee9b144193caa8e7ff7baeeb6f
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-12-25 02:34:39 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2021-12-25 02:34:39 +0000

    games/seabattle: update to 1.1 and unbreak on FreeBSD 13+

    After having sent a number of FreeBSD patches to the author, he
    updated the project and incorporated them.  So this is mainly a
    patch release.

    Port changes:
    - remove patches incorporated by upstream
    - unbreak build on FreeBSD 13+
    - set LICENSE to MIT
    - depend on audio/alsa-utils if audio output is desired
    - take up maintainership of this unmaintained port

    PR:             260633
    Reported by:    Robert Clausecker <fuz@fuz.su> (new maintainer)

 games/seabattle/Makefile                    | 24 +++++++++--------
 games/seabattle/distinfo                    |  5 ++--
 games/seabattle/files/patch-Makefile (gone) | 29 --------------------
 games/seabattle/files/patch-batt.c (gone)   | 11 --------
 games/seabattle/files/patch-batt.h (gone)   | 20 --------------
 games/seabattle/files/patch-bdb.c (gone)    | 31 ----------------------
 games/seabattle/files/patch-binp.c (gone)   | 41 -----------------------------
 games/seabattle/pkg-plist                   |  3 ++-
 8 files changed, 18 insertions(+), 146 deletions(-)
Comment 4 Hiroki Tagato freebsd_committer freebsd_triage 2021-12-25 02:39:25 UTC 
Committed, thanks!