Bug 260646 - multimedia/pipewire: Fails to build when ports OpenSSL installed: module-raop-sink.c: multiple errors
Summary: multimedia/pipewire: Fails to build when ports OpenSSL installed: module-raop...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Gleb Popov
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2021-12-23 17:42 UTC by Ashish SHUKLA
Modified: 2021-12-24 18:17 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (arrowd)
koobs: merge-quarterly?

Attachments
poudriere failure log (417.43 KB, text/plain)
2021-12-23 17:42 UTC, Ashish SHUKLA 		no flags Details
patch to fix (1.00 KB, patch)
2021-12-23 17:46 UTC, Ashish SHUKLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ashish SHUKLA freebsd_committer freebsd_triage 2021-12-23 17:42:58 UTC 
Created attachment 230354 [details]
poudriere failure log
Comment 1 Ashish SHUKLA freebsd_committer freebsd_triage 2021-12-23 17:46:17 UTC 
Created attachment 230355 [details]
patch to fix

The attached patch includes:

 - a patch to fix the compiler error

 - disable the codepath (raop option) altogether to not trigger the compiler error

I'm not a user of pipewire, only came across when building gnome-terminal port, so perhaps maintainer can decide to add a OPTION for raop pipewire option which will require depending on openssl port, or just disable it altogether.

HTH
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-12-24 18:15:20 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=463583e8beb0757fbfb2eeb360f1f23e7f7791b0

commit 463583e8beb0757fbfb2eeb360f1f23e7f7791b0
Author:     Gleb Popov <arrowd@FreeBSD.org>
AuthorDate: 2021-12-24 18:13:01 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2021-12-24 18:14:03 +0000

    multimedia/pipewire: Teach the port to use OpenSSL.

    Enable raop plugin that was previosly disabled.

    PR:             260646

 multimedia/pipewire/Makefile                         |  6 ++++--
 multimedia/pipewire/files/patch-meson.build (new)    | 20 ++++++++++++++++++++
 .../files/patch-src_modules_module-raop-sink.c (new) | 10 ++++++++++
 multimedia/pipewire/pkg-plist                        |  1 +
 4 files changed, 35 insertions(+), 2 deletions(-)
Comment 3 Gleb Popov freebsd_committer freebsd_triage 2021-12-24 18:17:27 UTC 
The correct fix is to explicitly enable raop module and teach the Meson build system to properly locate both base and ports OpenSSL.