Bug 260674 - graphics/darktable: Update to 3.8.0
Summary: graphics/darktable: Update to 3.8.0
Status: Closed DUPLICATE of bug 262363
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jean-Sébastien Pédron
URL:
Keywords:
Depends on: 262363
Blocks:
  Show dependency treegraph
 
Reported: 2021-12-25 09:19 UTC by Li-Wen Hsu
Modified: 2022-03-18 23:05 UTC (History)
4 users (show)

See Also:
dumbbell: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Li-Wen Hsu freebsd_committer freebsd_triage 2021-12-25 09:19:39 UTC
This is the first patch for updating darktable to 3.8.0. I updated the distinfo and pkg-plist, cleaned up the local patches, but haven't checked all the build option combinations and if any needs to be added or removed.

The patch is at https://github.com/lwhsu/freebsd-ports/commit/0b7bdf03586918b66ed9233d01a62c01940869fc.patch

The working branch is at https://github.com/lwhsu/freebsd-ports/tree/darktable-3.8.0
Comment 1 Matthias Andree freebsd_committer freebsd_triage 2021-12-29 21:22:52 UTC
This port needs an additional libheif.so:graphics/libheif in LIB_DEPENDS. 

We need to update LUA_USES=lua:54 (was :53).
Comment 2 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2021-12-29 21:33:21 UTC
Hi!

Thank you for the patch! I will try to find time to test it on Friday or during the first week of January.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-12-30 00:20:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b515b33388239d2c867e20adf797c64892913cda

commit b515b33388239d2c867e20adf797c64892913cda
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2021-12-30 00:14:23 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2021-12-30 00:18:34 +0000

    graphics/darktable38: new v3.8 of raw developer

    This port is meant to fill the gap until we can upgrade
    graphics/darktable (which is v3.6), so that we have 3.8 in 2022Q1,
    and to avoid breaking darktable for the latter in case new issues
    show up, as darktable 3.8 is fairly new at the time of commit.

    This is based on prior work by the graphics/darktable port maintainers,
    dumbbell@ and lwhsu@.

    Versus v3.6, we re-enable ninja builds but LTO with RawSpeed
    currently does not work. For that to work, we need to BINARY_ALIAS
    the linker, to avoid picking up the base system linker with a newer
    LLVM toolchain from ports (no matter if 12 or 13).

    related to
    PR:             260674

 graphics/Makefile                                  |   1 +
 graphics/darktable38/Makefile (new)                | 167 ++++++++
 graphics/darktable38/distinfo (new)                |   3 +
 .../patch-cmake_modules_FindOpenEXR.cmake (new)    |  12 +
 .../files/patch-src_CMakeLists.txt (new)           |  11 +
 ...al_rawspeed_cmake_Modules_CheckZLIB.cmake (new) |  11 +
 .../patch-src_is__supported__platform.h (new)      |  11 +
 graphics/darktable38/pkg-descr (new)               |  21 +
 graphics/darktable38/pkg-plist (new)               | 422 +++++++++++++++++++++
 9 files changed, 659 insertions(+)
Comment 4 Matthias Andree freebsd_committer freebsd_triage 2021-12-30 00:25:58 UTC
Jean-Sébastien, if you can have a look how we could fix the rawspeed LTO build issues, that would be much appreciated, too.

I tried a bit but did not succeed, and am getting unresolved linker symbols that I cannot quite explain because llvm-nm13 will list the "missing" functions, and won't be able to look into this before somewhen in January.
Comment 5 Matthias Andree freebsd_committer freebsd_triage 2022-03-05 16:42:40 UTC

*** This bug has been marked as a duplicate of bug 262363 ***
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-03-18 23:05:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=80c4d9abe1dd41acce04b39641138912f66cb374

commit 80c4d9abe1dd41acce04b39641138912f66cb374
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2022-02-28 03:06:50 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2022-03-18 23:04:50 +0000

    graphics/darktable: update to 3.8.1

    After having matured this code in graphics/darktable38 for two months,
    showtime. Let's upgrade graphics/darktable to 3.8.1.

    Note: LTO on RawSpeed still does not work, ninja re-enabled.

    Rename option from LIBAVIF to AVIF.

    Convert all <opt>_CMAKE_OFF to <opt>_CMAKE_BOOL
    for tighter control of options.

    ChangeLog:
    + https://github.com/darktable-org/darktable/releases/tag/release-3.8.0
    + https://github.com/darktable-org/darktable/releases/tag/release-3.8.1

    PR:             260674

    Approved by:    dumbbell@ (maintainer timeout, 14 d)
    dumbbell@ was positive to committing a previous version of this, earlier

 MOVED                                              |   1 +
 graphics/Makefile                                  |   1 -
 graphics/darktable/Makefile                        |  49 ++-
 graphics/darktable/distinfo                        |   6 +-
 ...ch-src_external_OpenCL_CL_cl__platform.h (gone) |  13 -
 graphics/darktable/pkg-plist                       |  16 +-
 graphics/darktable38/Makefile (gone)               | 172 ---------
 graphics/darktable38/distinfo (gone)               |   3 -
 .../patch-cmake_modules_FindOpenEXR.cmake (gone)   |  12 -
 .../files/patch-src_CMakeLists.txt (gone)          |  11 -
 ...l_rawspeed_cmake_Modules_CheckZLIB.cmake (gone) |  11 -
 .../patch-src_is__supported__platform.h (gone)     |  11 -
 graphics/darktable38/pkg-descr (gone)              |  21 -
 graphics/darktable38/pkg-plist (gone)              | 423 ---------------------
 14 files changed, 43 insertions(+), 707 deletions(-)