Bug 260697 - games/lmpc: enable on more 32 bit architectures
Summary: games/lmpc: enable on more 32 bit architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-26 10:28 UTC by Robert Clausecker
Modified: 2022-01-02 06:54 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (danfe)


Attachments
games/lmpc: enable on more 32 bit architectures (1.27 KB, patch)
2021-12-26 10:28 UTC, Robert Clausecker
fuz: maintainer-approval? (danfe)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2021-12-26 10:28:29 UTC
Created attachment 230418 [details]
games/lmpc: enable on more 32 bit architectures

Not just i386 has sizeof(long) == 4, so change port such that it refuses to build on 64 bit architectures instead of building just on i386.

Also define MAKE_JOBS_UNSAFE as the port seems to have not
correctly registered a dependency of udeml.c on udemy.h.

Tested with Poudriere on armv7 FreeBSD 13.
Comment 1 Alexey Dokuchaev freebsd_committer freebsd_triage 2021-12-26 11:11:54 UTC
(In reply to Robert Clausecker from comment #0)
> Not just i386 has sizeof(long) == 4
You're right, but NOT_FOR_ARCHS is probably poor choice in his particular case as it would likely grow in the future (cf. ONLY_FOR_ARCHS).

> the port seems to have not correctly registered a dependency of udeml.c
> on udemy.h.
Interesting, I'll try to fix the bug rather than marking the port as -jX unsafe.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-01-02 06:49:58 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=877cceb2366ec51535ac0ad1ba0765dd16227fcd

commit 877cceb2366ec51535ac0ad1ba0765dd16227fcd
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2022-01-02 06:48:40 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2022-01-02 06:48:40 +0000

    games/lmpc: allow the port to build on more 32-bit architectures

    Convert to idiomatic ONLY_FOR_ARCHS and register one more object
    file which depends on the generated "udemy.h" header file to fix
    parallel builds (-jX).

    While here, adjust LICENSE (it is GPLv2 or later) and factor out
    installation of documentation into the dedicated helper target.

    PR:             260697
    Submitted by:   Robert Clausecker

 games/lmpc/Makefile | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)
Comment 3 Alexey Dokuchaev freebsd_committer freebsd_triage 2022-01-02 06:54:20 UTC
The port had been improved based on your suggestions, thanks!