Created attachment 230512 [details] math/sundials: update to version 6.0.0 This patch updates math/sundials to version 6.0.0. The release notes are at https://github.com/LLNL/sundials/releases/tag/v6.0.0. The changes to the ports' Makefile are as follows: - Bump version number to 6.0.0 - Add -DCMAKE_C_STANDARD=99 to CMAKE_ARGS; this fixes the LAPACK option. - Add LAPACK as default option - Remove -DSUNDIALS_INDEX_TYPE:STRING=int64_t, since this is automatically determined based on SUNDIALS_INDEX_SIZE which defaults to 64 bits. SUNDIALS_INDEX_TYPE has been deprecated with release 3.2.0. - Remove LAPACK_BROKEN - Remove {BLAS,LAPACK}_CMAKE_ON, since CMake warns during configuring that FREEBSD_GCC_DIR is not used - Reenable the OPENMP option - Replace BLAS_ENABLE by ENABLE_BLAS; this silences a warning - Switch the MPI option to CMAKE_BOOL - Add HYPRE_BROKEN, since configure errors out when trying to build with hypre support distinfo and pkg-plist have been updated accordingly. poudriere is happy: I tested the port with 12.2-Release i386, 12.3-Release and 13.0-Release amd64. The SUNDIALS testsuite passes without any errors.
Thank you for the patch. Unfortunately this update broke math/octave: > libinterp/dldfcn/__ode15__.cc:420:26: error: no matching function for call to 'SUNDenseMatrix' > m_sunJacMatrix = SUNDenseMatrix (m_num, m_num); > ^~~~~~~~~~~~~~ Octave bug: https://savannah.gnu.org/bugs/index.php?61738
It looks like we need to wait for Octave 7 to be released because this issue is fixed there.
Any chance to incorporate this patch? Should I update it for the current version?
(In reply to Philipp Ost from comment #3) Hi Philipp, Sorry, I overlooked this PR. I'll incorporate the delta this week. Yuri
Remaining changes committed. Thanks for the patch!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7f9cd79566fd1f8d159b25ee9bf4678af1fadc39 commit 7f9cd79566fd1f8d159b25ee9bf4678af1fadc39 Author: Yuri Victorovich <yuri@FreeBSD.org> AuthorDate: 2022-06-29 06:05:06 +0000 Commit: Yuri Victorovich <yuri@FreeBSD.org> CommitDate: 2022-06-29 06:11:17 +0000 math/sundials: Multiple changes - add -DCMAKE_C_STANDARD=99 to CMAKE_ARGS; this fixes the LAPACK option - remove -DSUNDIALS_INDEX_TYPE:STRING=int64_t, since this is automatically determined based on SUNDIALS_INDEX_SIZE which defaults to 64 bits. SUNDIALS_INDEX_TYPE has been deprecated with release 3.2.0 - make LAPACK default - remove LAPACK_BROKEN - remove {BLAS,LAPACK}_CMAKE_ON, since CMake warns during configuring that FREEBSD_GCC_DIR is not used - reenable OPENMP option - replace BLAS_ENABLE with ENABLE_BLAS; this silences a warning - switch the MPI option to CMAKE_BOOL - add HYPRE_BROKEN, since configure errors out when trying to build with hypre support PR: 260771 Original patch submitted by: Philipp Ost <bsd@philippost.de> math/sundials/Makefile | 19 ++++++++++--------- math/sundials/pkg-plist | 10 ++++++---- 2 files changed, 16 insertions(+), 13 deletions(-)