Bug 260853 - net/sofia-sip: update to 1.13.6
Summary: net/sofia-sip: update to 1.13.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Hiroki Tagato
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-31 21:21 UTC by Dustin Marquess
Modified: 2022-01-05 07:26 UTC (History)
2 users (show)

See Also:

Attachments
sofia-sip update patch (1.78 KB, application/mbox)
2021-12-31 21:21 UTC, Dustin Marquess 		no flags Details
Updated patch (1.76 KB, patch)
2022-01-04 08:39 UTC, Dustin Marquess 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dustin Marquess 2021-12-31 21:21:00 UTC 
Created attachment 230595 [details]
sofia-sip update patch

Update to net/sofia-sip to 1.13.6.

Mark as no longer unmaintained.

I ran a poudriere build on these ports that depend on sofia-sip and all of them built successfully:

comms/deforaos-phone
net/freeswitch
net-im/telepathy-sofiasip
www/janus
Comment 1 Hiroki Tagato freebsd_committer freebsd_triage 2022-01-04 00:19:27 UTC 
Thanks for picking up this unmaintained port.

One comment:
- When DISTVERSION advances, PORTREVISION is reset. So can you remove the PORTREVISION line in the patch?

Thanks!
Comment 2 Dustin Marquess 2022-01-04 08:39:23 UTC 
Created attachment 230679 [details]
Updated patch

I thought that's how PORTREVISION worked based upon my interpretation of the docs, but the last time I submitted a patch, I was told that any time a library has its major soversion bumped, PORTREVISION should be bumped, even if the package version is also bumped. That didn't make sense to me, but who was I to argue?

Updated the patch to remove PORTREVISION, thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-01-05 07:23:27 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=75454ead07fd0387d048c05ccd1f377252763bdf

commit 75454ead07fd0387d048c05ccd1f377252763bdf
Author:     Dustin Marquess <jailbird@fdf.net>
AuthorDate: 2022-01-05 07:20:31 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2022-01-05 07:22:06 +0000

    net/sofia-sip: update to 1.13.6

    While here, pass maintainership to submitter.

    PR:             260853
    Reported by:    Dustin Marquess <jailbird@fdf.net> (new maintainer)

 net/sofia-sip/Makefile  | 4 ++--
 net/sofia-sip/distinfo  | 6 +++---
 net/sofia-sip/pkg-plist | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)
Comment 4 Hiroki Tagato freebsd_committer freebsd_triage 2022-01-05 07:26:57 UTC 
Committed, thanks!