Bug 260860 - audio/jamulus-server: fix server options
Summary: audio/jamulus-server: fix server options
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-01 13:02 UTC by Stefan Bethke
Modified: 2022-01-03 07:23 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
modified rc script (819 bytes, application/x-shellscript)
2022-01-01 13:02 UTC, Stefan Bethke
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Bethke 2022-01-01 13:02:55 UTC
Created attachment 230604 [details]
modified rc script

I've added server options in /etc/rc.conf, but the rc system adds them to the command (ie. daemon), which of course doesn't understand them. I believe modifying the rc script like this is more in line with the rc system.
Comment 1 Stefan Bethke 2022-01-01 13:03:48 UTC
Sorry, this should
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2022-01-03 07:10:14 UTC
Hi Stefan,

Thanks for the report.

I've committed a simpler patch that does what you suggested.

Please let me know if you would have any further concerns.


Thanks,
Yuri
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-01-03 07:10:57 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5e56a22d7125752516dcbf1b89534d38de0bbb9a

commit 5e56a22d7125752516dcbf1b89534d38de0bbb9a
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2022-01-03 07:05:56 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-01-03 07:10:14 +0000

    audio/jamulus: Fix jamulus-server arguments

    * allow to override user name for the daemon with jamulus_server_uname
    * allow to set server arguments with jamulus_server_args

    PR:             260860
    Reported by:    Stefan Bethke <stb@lassitu.de>

 audio/jamulus/Makefile                |  1 +
 audio/jamulus/files/jamulus-server.in | 12 ++++++++----
 2 files changed, 9 insertions(+), 4 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-01-03 07:23:59 UTC
A commit in branch 2022Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b3d1562709b1135f1792dc40b47af195622325bc

commit b3d1562709b1135f1792dc40b47af195622325bc
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2022-01-03 07:05:56 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-01-03 07:23:10 +0000

    audio/jamulus: Fix jamulus-server arguments

    * allow to override user name for the daemon with jamulus_server_uname
    * allow to set server arguments with jamulus_server_args

    PR:             260860
    Reported by:    Stefan Bethke <stb@lassitu.de>

    (cherry picked from commit 5e56a22d7125752516dcbf1b89534d38de0bbb9a)

 audio/jamulus/Makefile                |  1 +
 audio/jamulus/files/jamulus-server.in | 12 ++++++++----
 2 files changed, 9 insertions(+), 4 deletions(-)